Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 628076 - x11-libs/gtk+-3.22.17: circular dependency on x11-themes/adwaita-icon-theme-3.24.0
Summary: x11-libs/gtk+-3.22.17: circular dependency on x11-themes/adwaita-icon-theme-3...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-16 23:32 UTC by Zac Medico
Modified: 2017-08-27 14:27 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zac Medico gentoo-dev 2017-08-16 23:32:16 UTC
In x11-themes/adwaita-icon-theme-3.24.0, x11-libs/gtk+:3 was added to DEPEND:

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a6dff57628e5d106b6d2228cfadcbab3bde8368d

This creates a circular dependency:

> * Error: circular dependencies:
> 
> (x11-themes/adwaita-icon-theme-3.24.0:0/0::gentoo, ebuild scheduled for merge) depends on
>  (x11-libs/gtk+-3.22.17:3/3::gentoo, ebuild scheduled for merge) (buildtime)
>   (x11-themes/adwaita-icon-theme-3.24.0:0/0::gentoo, ebuild scheduled for merge) (runtime)

Maybe the gtk+-3.22.17 ebuild can move >=x11-themes/adwaita-icon-theme-3.14 to PDEPEND?
Comment 1 Austin English (RETIRED) gentoo-dev 2017-08-17 17:26:21 UTC
Doing emerge --nodeps x11-themes/adwaita-icon-theme, then emerging @world allowed me to break the circular dep.
Comment 2 Zac Medico gentoo-dev 2017-08-17 17:47:50 UTC
(In reply to Austin English from comment #1)
> Doing emerge --nodeps x11-themes/adwaita-icon-theme, then emerging @world
> allowed me to break the circular dep.

Okay, so maybe the PDEPEND belongs in the adwaita-icon-theme ebuild then.
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2017-08-17 21:07:30 UTC
It was added as adwaita-icon-theme needs a tool provided by gtk+ to build.
I think the best we can do is to split this tool out if possible, like gtk-update-icon-cache.
Comment 4 Mart Raudsepp gentoo-dev 2017-08-20 09:36:19 UTC
I don't think gtk+ needs anything out of adwaita to build, so PDEPEND in gtk+ sounds good I think? adwaita-icon-theme dep in gtk+ is RDEPEND ONLY there already, but apparently we need to make use of PDEPEND there, as portage seems to not figure out what to do or something.
Comment 5 Zac Medico gentoo-dev 2017-08-20 09:50:17 UTC
(In reply to Mart Raudsepp from comment #4)
> I don't think gtk+ needs anything out of adwaita to build, so PDEPEND in
> gtk+ sounds good I think? adwaita-icon-theme dep in gtk+ is RDEPEND ONLY
> there already, but apparently we need to make use of PDEPEND there, as
> portage seems to not figure out what to do or something.

PMS thing https://dev.gentoo.org/~ulm/pms/head/pms.html#x1-740008:

> Runtime dependencies (RDEPEND). These must be installed and usable before
> the results of an ebuild merging are treated as usable.
Comment 6 Toralf Förster gentoo-dev 2017-08-22 18:16:00 UTC
I had to add currently

app-crypt/pinentry        -gtk
sys-auth/polkit           -gtk
app-crypt/gcr             -gtk

here to my tinderbox images to circumvent this issue.
Comment 7 Mart Raudsepp gentoo-dev 2017-08-27 14:27:33 UTC
Fixed in 3.22.17 and 3.22.19. We will need to stabilize one of those (or any newer) before adwaita-icon-theme-3.24, but I plan to soon anyways, and will be together in the big GNOME 3.24 set anyways for sure in the slightly more distant future.

commit dab39d90ee5ce42e5d5c6694853a8080af0fd4c2
Author: Mart Raudsepp <leio@gentoo.org>
Date:   Sun Aug 27 17:25:59 2017 +0300

    x11-libs/gtk+: Move adwaita-icon-theme to PDEPEND to fix circular dep
    
    adwaita-icon-theme requires gtk+:3 at build time to properly generate the
    symbolic PNG icons from SVG files with the gtk-encode-symbolic-svg tool,
    which is shipped by gtk+:3. Thus adwaita-icon-theme depend in gtk+:3 can
    not be a runtime only RDEPEND, but has to be PDEPEND due to PMS rule:
    "Runtime dependencies (RDEPEND). These must be installed and usable before
    the results of an ebuild merging are treated as usable."
    Should be fine to install adwaita-icon-theme afterwards in the order, to
    satisfy default theme icons.
    
    Gentoo-bug: 628076
    Package-Manager: Portage-2.3.6, Repoman-2.3.2