Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 627752 - virtual/bitcoin-leveldb-0-r1 depends on dev-libs/leveldb-1.18-r1 but -r2 is stable
Summary: virtual/bitcoin-leveldb-0-r1 depends on dev-libs/leveldb-1.18-r1 but -r2 is s...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Luke-Jr
URL:
Whiteboard:
Keywords:
: 627830 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-08-13 06:25 UTC by Markus
Modified: 2017-08-18 08:41 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus 2017-08-13 06:25:16 UTC
=dev-libs/leveldb-1.18-r1 does not exist in tree anymore
=dev-libs/leveldb-1.18-r2 is current stable in tree
virtual/bitcoin-leveldb-0-r1 depends on r1 but not on r2


WARNING: One or more updates/rebuilds have been skipped due to a dependency conflict:

dev-libs/leveldb:0

  (dev-libs/leveldb-1.18-r2:0/0::gentoo, ebuild scheduled for merge) conflicts with
    =dev-libs/leveldb-1.18-r1 required by (virtual/bitcoin-leveldb-0-r1:0/0::gentoo, installed)
Comment 1 Andreas Sturmlechner gentoo-dev 2017-08-13 12:09:52 UTC
I'm questioning the purpose of virtual/bitcoin-leveldb.
Comment 2 Luke-Jr 2017-08-13 19:59:00 UTC
PR opened for this 9 days ago: https://github.com/gentoo/gentoo/pull/5298

The virtual in the bitcoin overlay is already up-to-date.

See this comment for rationale behind the virtual: https://github.com/gentoo/gentoo/pull/5298#issuecomment-322062934

(It would be nice if LevelDB versions didn't get pruned immediately.)
Comment 3 Andreas Sturmlechner gentoo-dev 2017-08-15 09:52:29 UTC
*** Bug 627830 has been marked as a duplicate of this bug. ***
Comment 4 Andreas Sturmlechner gentoo-dev 2017-08-15 09:57:02 UTC
(In reply to Luke-Jr from comment #2)
> See this comment for rationale behind the virtual:
> https://github.com/gentoo/gentoo/pull/5298#issuecomment-322062934
> 
> LevelDB is part of Bitcoin's consensus logic. The nature of consensus code is
> such that it must guarantee bug-for-bug compatibility, especially for data-loss
> bugs. It would be unreasonable to expect upstream LevelDB to make such a
> guarantee (and indeed, they do not), so instead what we typically do for
> Bitcoin is bundle the library in the code, and review new releases to ensure
> they do not fix any bugs that would break this compatibility. Similarly, it
> would be unreasonable for the Gentoo packager of LevelDB to make this
> guarantee, as other software using LevelDB would expect to have such bugs fixed
> - indeed, if such a bug were critical enough, it might even get backported in a
> -rN package revision.
> 
> Ordinarily, we advise distros to not package Bitcoin at all, since the nature
> of consensus code is unfamiliar to most packagers, and distros are generally
> not capable of making this bug-for-bug compatibility guarantee. However, Gentoo
> is an exception to the rule here, since we can use a virtual to ensure only
> known-compatible LevelDBs are used in combination with Bitcoin.
Comment 5 Andreas Sturmlechner gentoo-dev 2017-08-15 10:08:51 UTC
commit e8bc28b6fddacb407c3d4c03ed0a3a0633c20870
Author: Luke Dashjr <luke-jr+git@utopios.org>
Date:   Fri Aug 4 17:23:48 2017 +0000

    virtual/bitcoin-leveldb: Add =dev-libs/leveldb-1.18-r2
Comment 6 Ladislav Zitka 2017-08-18 08:41:13 UTC
Yes, it works now, thx guys!