Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 627698 - app-admin/logrotate: Please revert bzip2 changes
Summary: app-admin/logrotate: Please revert bzip2 changes
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Chema Alonso Josa (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-12 13:53 UTC by Thomas Deutschmann (RETIRED)
Modified: 2017-08-28 15:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Deutschmann (RETIRED) gentoo-dev 2017-08-12 13:53:27 UTC
Hi,

please consider reverting changes from bug 621850. While I understand the feature request, the patch (change) is intransparent and therefor wrong:

If people want to use bzip2 they should set

> compresscmd     /usr/bin/bzip2
> uncompresscmd   /usr/bin/bunzip2
> compressoptions --best
> compressext     bz2

in their /etc/logrotate.conf for example.

For me, the changes are wrong because `man logrotate` still says "Old versions of log files are compressed with gzip(1) by default." So if you patch the default used compression, you also have to update documentation to be transparent.

Also remember that "bzip2" is a global USE flag which is enabled for most profiles. Also, app-arch/bzip2 is a base package. Therefor using a USE flag to control optional bzip2 usage (there is no build dependency on bzip2!) looks wrong for me, too.
Comment 1 Chema Alonso Josa (RETIRED) gentoo-dev 2017-08-28 15:43:10 UTC
Definetely right. =app-admin/logrotate-3.12.3-r1 reverts changes in bug #621850.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c9eb5579f753ed8995f9164853fcdfc92333a998

Thanks for the report.