Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 627450 - app-misc/datovka-4.9.2 version bump
Summary: app-misc/datovka-4.9.2 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Amy Liffey
URL:
Whiteboard:
Keywords:
Depends on: 624362
Blocks:
  Show dependency tree
 
Reported: 2017-08-10 10:53 UTC by karel.slany
Modified: 2017-08-28 20:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description karel.slany 2017-08-10 10:53:39 UTC
Datovka 4.9.1 has been released a while ago. This version adapts to planned changes in the API of the Czech eGov system which are going to be put into production at the beginning of September.

This version of Datovka also depends on net-libs/libisds-0.10.7 which, at the moment, is also missing in the portage tree.

Datovka-4.9.1 compiles and runs fine on amd64 and should also compile and run on x86.

project page: https://www.datovka.cz/
project repo: https://gitlab.labs.nic.cz/datovka/datovka
changelog: https://gitlab.labs.nic.cz/datovka/datovka/blob/master/ChangeLog

updated ebuild: https://gitlab.labs.nic.cz/kslany/ebuild-datovka/blob/master/datovka-4.9.1.ebuild
Comment 1 Jonas Stein gentoo-dev 2017-08-10 11:23:02 UTC
Thank you for your contribution. I had a short look on the ebuild. 
Here a few ideas:

* Please test the ebuild with repoman https://wiki.gentoo.org/wiki/Repoman
* We always try to use the latest EAPI, please bump to EAPI=6
* DESCRIPTION="GUI to access Czech eGov: Datove schranky"
  will fail less with scripts and is better to read
* I think the docompress and dodoc lines can be improved in EAPI 6
  https://devmanual.gentoo.org/ebuild-writing/eapi/
  https://blogs.gentoo.org/mgorny/2015/11/13/the-ultimate-guide-to-eapi-6/
Comment 2 karel.slany 2017-08-10 18:47:57 UTC
Thank you for all the suggestions how to improve the ebuild.

I was able to follow all your suggestion except of removing the docompress statement. Modifications in the source package would be needed which at the moment I find unnecessary.

I'm inclined to leave the docompress line in datovka-4.9.1 ebuild. I'll try fixing the source file package and remove the statement in following datovka-4.9.2 .

updated ebuild: https://gitlab.labs.nic.cz/kslany/ebuild-datovka/blob/master/datovka-4.9.1.ebuild
Comment 3 Amy Liffey gentoo-dev 2017-08-10 19:24:04 UTC
(In reply to karel.slany from comment #2)
> Thank you for all the suggestions how to improve the ebuild.
> 
> I was able to follow all your suggestion except of removing the docompress
> statement. Modifications in the source package would be needed which at the
> moment I find unnecessary.
> 
> I'm inclined to leave the docompress line in datovka-4.9.1 ebuild. I'll try
> fixing the source file package and remove the statement in following
> datovka-4.9.2 .
> 
> updated ebuild:
> https://gitlab.labs.nic.cz/kslany/ebuild-datovka/blob/master/datovka-4.9.1.
> ebuild

https://gitlab.com/Zelena/hell-overlay/blob/master/app-misc/datovka/datovka-4.9.1.ebuild

How about this would this work?
Comment 4 karel.slany 2017-08-11 07:31:49 UTC
(In reply to Amy Liffey from comment #3)
> (In reply to karel.slany from comment #2)
> > Thank you for all the suggestions how to improve the ebuild.
> > 
> > I was able to follow all your suggestion except of removing the docompress
> > statement. Modifications in the source package would be needed which at the
> > moment I find unnecessary.
> > 
> > I'm inclined to leave the docompress line in datovka-4.9.1 ebuild. I'll try
> > fixing the source file package and remove the statement in following
> > datovka-4.9.2 .
> > 
> > updated ebuild:
> > https://gitlab.labs.nic.cz/kslany/ebuild-datovka/blob/master/datovka-4.9.1.
> > ebuild
> 
> https://gitlab.com/Zelena/hell-overlay/blob/master/app-misc/datovka/datovka-
> 4.9.1.ebuild
> 
> How about this would this work?

It surely compiles. But the package expects AUTHORS and COPYING to be located in directory /usr/share/doc/datovka . Those files must not be compressed in order for the application to properly display licensing and credit information.

As I stated before, I'm willing to make modifications in the sources of the following version 4.9.2. Patching the sources of 4.9.1 just to be able to use the fancy EAPI=6 I consider a waste of time.

BTW, how do I with EAPI=6 achieve that specified documentation files are compressed? I wasn't able to find this information in the documentation.
Comment 5 karel.slany 2017-08-11 07:34:04 UTC
I'm sorry I wanted to ask:
How do I with EAPI=6 achieve that specified documentation files aren't compressed?
Comment 6 karel.slany 2017-08-28 14:24:10 UTC
We've released Datovka-4.9.2 just a moment ago. I've modified the ebuild so that the usage of docompress isn't necessary.

updated ebuild: https://gitlab.labs.nic.cz/kslany/ebuild-datovka/blob/master/datovka-4.9.2.ebuild
Comment 7 Amy Liffey gentoo-dev 2017-08-28 20:37:39 UTC
commit d10928636cc9dd4793a37c56070a251f9fd2971e 
Author: Amy Liffey <amynka@gentoo.org>
Date:   Mon Aug 28 22:36:03 2017 +0200

    app-misc/datovka: version bump 4.9.2 bug #627450
    
    Submitted-by: <karel.slany@nic.cz>
Comment 8 Amy Liffey gentoo-dev 2017-08-28 20:38:04 UTC
(In reply to Amy Liffey from comment #7)
> commit d10928636cc9dd4793a37c56070a251f9fd2971e 
> Author: Amy Liffey <amynka@gentoo.org>
> Date:   Mon Aug 28 22:36:03 2017 +0200
> 
>     app-misc/datovka: version bump 4.9.2 bug #627450
>     
>     Submitted-by: <karel.slany@nic.cz>

Thank you Karel! :)