Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 626884 - =dev-python/sdnotify-0.3.1 installs stray files/will cause collisions
Summary: =dev-python/sdnotify-0.3.1 installs stray files/will cause collisions
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-02 15:49 UTC by Daniel M. Weeks
Modified: 2020-03-29 08:32 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel M. Weeks 2017-08-02 15:49:32 UTC
sdnotify installs /usr/LICENSE.txt as a result of (incorrectly) including it in data_files within setup.py. I've had a quick fix in my overlay for a couple months and I've just pushed a real fix upstream:

https://github.com/doctaweeks/junkdrawer-overlay/blob/master/dev-python/sdnotify/files/sdnotify-no-doc.patch
https://github.com/bb4242/sdnotify/pull/3

This is actually a wider problem for python packages - abusing data_files to install directly into the prefix root. I've found it more than once - crossbar, txio - both still affected). It would be good for portage, or at lease the python eclasses, to check for stray files that are likely to cause collisions. I have a hook in my portage bashrc that I use to alert me to such problems: https://danweeks.net/p-blog?id=8

The only reason this does not currently cause a collision with dev-python/crossbar is a sed hack in the crossbar ebuild.

Reproducible: Always
Comment 1 Daniel M. Weeks 2017-08-02 15:55:22 UTC
> The only reason this does not currently cause a collision with
> dev-python/crossbar is a sed hack in the crossbar ebuild.

Sorry, ignore. This applies to another package on bug # 626886.
Comment 2 Daniel M. Weeks 2017-08-02 21:25:58 UTC
The patch has been accepted upstream and a new version has been released (0.3.2)
Comment 3 Brian Dolbec (RETIRED) gentoo-dev 2017-08-15 18:09:16 UTC
Awesome, thanks,  haven't had time yet, but I'll get to that bump as soon as I can.  I must have missed that.  Did you mean txaio also does this? DAMN, :(  I'll get that one fixed too.  

Yeah, I had to sed that out for crossbar.  I don't remember if if was your patch for sdnotify, but please submit the same for crossbar :) if there isn't one already.  I seem to remember adding a +1 somewhere for a patch like that.

From what I've seen, all these various deps around and including buildbot seem to think they should all be virtualenv installs...  So likely can get away with those stupid things...


Thank you for the reports and help.
Comment 4 Daniel M. Weeks 2017-08-15 18:17:03 UTC
(In reply to Brian Dolbec from comment #3)
> Awesome, thanks,  haven't had time yet, but I'll get to that bump as soon as
> I can.  I must have missed that.  Did you mean txaio also does this? DAMN,
> :(  I'll get that one fixed too.  
> 

Yes, there are several packages in this ecosystem that abuse data_files and txaio is one of them.

> Yeah, I had to sed that out for crossbar.  I don't remember if if was your
> patch for sdnotify, but please submit the same for crossbar :) if there
> isn't one already.  I seem to remember adding a +1 somewhere for a patch
> like that.

Yes, my patch was accepted for sdnotify but rejected for crossbar. I submitted a similar patch for txaio but it is still waiting. However, I predict it will be rejected too since it is a crossbar project...

> 
> From what I've seen, all these various deps around and including buildbot
> seem to think they should all be virtualenv installs...  So likely can get
> away with those stupid things...
> 

Yes, this was one of the things I was told when the crossbar patch was rejected: "we certainly don't recommend installing Crossbar.io into the host system" Unfortunate...
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-03-29 08:32:42 UTC
Old version removed.  Please reopen if it still happens.