Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 62568 - XMMS: Enable Shoutcast title streaming by default
Summary: XMMS: Enable Shoutcast title streaming by default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Jeremy Huddleston (RETIRED)
URL: http://etc.no-ip.org:8080
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-01 17:06 UTC by Nick Hadaway
Modified: 2004-10-03 16:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to turn on shoutcast title display by default (xmms-1.2.10-cast_title_streaming_true.patch,598 bytes, patch)
2004-09-04 16:44 UTC, inode77
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Hadaway 2004-09-01 17:06:33 UTC
Many people coming from the wonderful world of winamp to xmms will find the default configuration of the mpg123 plugin annoying.  Shoutcast stream and song titles are dynamically updated and xmms can handle this but doesn't by default.

In ~/.xmms/config there is an option for this... cast_title_streaming=TRUE

Making a simple change to ${S}/Input/mpg123/configure.c sets this option to on by default.

Reproducible: Always
Steps to Reproduce:
1. emerge xmms
2. Open http://etc.no-ip.org:8080

Actual Results:  
Only the stream name is displayed

Expected Results:  
Acted like winamp and updated the scrolling display with the artist and song
title information.
Comment 1 Jeremy Huddleston (RETIRED) gentoo-dev 2004-09-02 09:38:01 UTC
Ok, if someone can make this patch, I'll throw it in the next patchset.
Comment 2 inode77 2004-09-04 16:44:35 UTC
Created attachment 38944 [details, diff]
Patch to turn on shoutcast title display by default

ebuild diff:

--- /usr/portage/media-sound/xmms/xmms-1.2.10-r5.ebuild 2004-08-19
04:35:55.000000000 +0200
+++ /usr/local/portage/media-sound/xmms/xmms-1.2.10-r5.ebuild	2004-09-05
01:19:56.069264520 +0200
@@ -101,6 +101,9 @@
		chmod +x ${S}/config.rpath
	fi

+	# Bug #62568 ... Patch to enable shoutcast title streaming by default 
+	epatch ${PATCHDIR}/${P}-cast_title_streaming_true.patch
+	
	# dtd updates Makefile.am, but not Makefile.in
	export WANT_AUTOCONF=2.5
	export WANT_AUTOMAKE=1.7
Comment 3 inode77 2004-09-04 16:53:48 UTC
Comment on attachment 38944 [details, diff]
Patch to turn on shoutcast title display by default

>diff -Naur xmms-1.2.10-orig/Input/mpg123/mpg123.c xmms-1.2.10/Input/mpg123/mpg123.c
>--- xmms-1.2.10-orig/Input/mpg123/mpg123.c	2004-09-05 00:06:53.343540104 +0200
>+++ xmms-1.2.10/Input/mpg123/mpg123.c	2004-09-05 01:11:21.290522784 +0200
>@@ -167,7 +167,8 @@
> 	mpg123_cfg.proxy_use_auth = FALSE;
> 	mpg123_cfg.proxy_user = NULL;
> 	mpg123_cfg.proxy_pass = NULL;
>-	mpg123_cfg.cast_title_streaming = FALSE;
>+	// Gentoo Bug #62568 <sige@bluewin.ch> 
>+	mpg123_cfg.cast_title_streaming = TRUE;
> 	mpg123_cfg.use_udp_channel = FALSE;
> 	mpg123_cfg.title_override = FALSE;
> 	mpg123_cfg.disable_id3v2 = FALSE;
Comment 4 Jeremy Huddleston (RETIRED) gentoo-dev 2004-10-03 16:35:21 UTC
just added to -r6.