Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 625556 - app-admin/rsyslog - Add Names to Default rsyslog Actions
Summary: app-admin/rsyslog - Add Names to Default rsyslog Actions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Thomas Deutschmann (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-18 17:22 UTC by Aaron U'Ren
Modified: 2017-08-12 18:22 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch with rsyslog action names (rsyslog_default_add_names.patch,2.20 KB, patch)
2017-07-18 17:22 UTC, Aaron U'Ren
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron U'Ren 2017-07-18 17:22:33 UTC
Created attachment 485566 [details, diff]
patch with rsyslog action names

It would be helpful to have names associated with the default rsyslog actions so that when pstats (http://www.rsyslog.com/doc/v8-stable/configuration/modules/impstats.html) is enabled in rsyslog you could tie actions to what they represent. Without names on actions you get output like the following:
rsyslogd-pstats: action 8: origin=core.action processed=0 failed=0 suspended=0 suspended.duration=0 resumed=0

With names on actions the output looks like
rsyslogd-pstats: mail_action: origin=core.action processed=0 failed=0 suspended=0 suspended.duration=0 resumed=0

As you can see this can make a big difference when it comes to debugging where messages are being queued and what is going on with rsyslog forwarding.

I've attached a first pass at a patch that would add what I consider to be reasonable names to the actions. Please review and let me know what you think.
Comment 1 Thomas Deutschmann (RETIRED) gentoo-dev 2017-07-18 18:14:38 UTC
That's a great enhancement. Thank you. I am just unsure about the default naming schema, i.e. "action_" prefix. I'll think about it/ping upstream for best practice before I'll add it.
Comment 2 Aaron U'Ren 2017-07-18 18:28:27 UTC
Sounds good! Thanks for your consideration!
Comment 3 Thomas Deutschmann (RETIRED) gentoo-dev 2017-08-12 18:22:41 UTC
Added with app-admin/rsyslog-8.29.0 via https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c3675fd960dd315ea50f5973ac8541bdfc9709bb

I picked "<type>_<name>" schema, as you can name inputs for example as well.