Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 625522 - games-misc/lolcat-90.8.8 version bump
Summary: games-misc/lolcat-90.8.8 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-18 14:16 UTC by tao
Modified: 2017-10-30 13:20 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
lolcat 90.8.8 (lolcat-90.8.8.ebuild,526 bytes, text/plain)
2017-07-18 14:16 UTC, tao
Details

Note You need to log in before you can comment on or make changes to this bug.
Description tao 2017-07-18 14:16:57 UTC
Created attachment 485394 [details]
lolcat 90.8.8

Current version does not depend on old dev-ruby/paint anymore https://github.com/busyloop/lolcat/commit/f058df9732ec3a8904fdd02071b3e45ec536db7f
Comment 1 Jonas Stein gentoo-dev 2017-07-18 21:27:23 UTC
Thank you for the ebuild, I had a short look at it

EAPI=5
could be bumped to EAPI=6 because we always prefer the latest EAPI, for new ebuilds

DESCRIPTION="Rainbows and unicorns!"

This should be elaborated. 

LICENSE="WTFPL-2"
Is wrong. 
https://github.com/busyloop/lolcat/blob/master/LICENSE

DEPEND="dev-vcs/git"
Why does the package depend on git? We could just use the tarball...
(I am not sure about this just looked 2 seconds at this)
Comment 2 James Le Cuirot gentoo-dev 2017-07-18 21:35:45 UTC
There was a pull request for this earlier this year.

https://github.com/gentoo/gentoo/pull/3575

I don't know why maffblaster didn't finish it, especially given he is a dev, but you may want to read the comments there.
Comment 3 tao 2017-07-19 14:19:10 UTC
#2 I’ve created new pull request https://github.com/gentoo/gentoo/pull/5137
Comment 4 Daniel Maslowski 2017-10-30 13:17:22 UTC
This has been resolved with https://github.com/gentoo/gentoo/commit/8194ebb4ae81cbc90c72089acdf725639abe3c61