625520 – app-crypt/pinentry-0.9.7-r1: disobeys setting of USE="-gnome-keyring" and USE="-qt4"

Bug 625520 - app-crypt/pinentry-0.9.7-r1: disobeys setting of USE="-gnome-keyring" and USE="-qt4"

Summary: app-crypt/pinentry-0.9.7-r1: disobeys setting of USE="-gnome-keyring" and USE...

Status:	RESOLVED INVALID

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	AMD64 Linux

Importance:	Normal normal (vote)
Assignee:	Kristian Fiskerstrand (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2017-07-18 14:16 UTC by Mircea Sava
Modified:	2017-07-20 11:50 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Mircea Sava 2017-07-18 14:16:54 UTC

I tried recently to strip pinentry of gnome-keyring support but in doing so I noticed that it also built qt4 support without the qt4 flag being set on.

Reproducible: Always

Steps to Reproduce:
1. echo 'app-crypt/pinentry -gnome-keyring' > /etc/portage/package.use/pinentry
2. emerge --oneshot app-crypt/pinentry
3. 
Actual Results:  
Initially, I had:

[I] app-crypt/pinentry
     Available versions:  0.9.7-r1 ~1.0.0 {caps emacs gnome-keyring gtk ncurses qt4 qt5 static}
     Installed versions:  0.9.7-r1(04:50:35 12/09/16)(gnome-keyring ncurses qt5 -caps -emacs -gtk -qt4 -static)

and:

Available pinentry binary implementations:
  [1]   pinentry-gnome3
  [2]   pinentry-qt *
  [3]   pinentry-curses
  [4]   pinentry-tty

After the rebuild:

[I] app-crypt/pinentry
     Available versions:  0.9.7-r1 ~1.0.0 {caps emacs gnome-keyring gtk ncurses qt4 qt5 static}
     Installed versions:  0.9.7-r1(13:48:33 07/18/17)(gnome-keyring ncurses qt5 -caps -emacs -gtk -qt4 -static)

and:

Available pinentry binary implementations:
  [1]   pinentry-gnome3
  [2]   pinentry-qt *
  [3]   pinentry-qt4
  [4]   pinentry-curses
  [5]   pinentry-tty

Expected Results:  
[I] app-crypt/pinentry
     Available versions:  0.9.7-r1 ~1.0.0 {caps emacs gnome-keyring gtk ncurses qt4 qt5 static}
     Installed versions:  0.9.7-r1(04:50:35 12/09/16)(ncurses qt5 -caps -emacs -gnome-keyring -gtk -qt4 -static)

and:

Available pinentry binary implementations:
  [1]   pinentry-qt *
  [2]   pinentry-curses
  [3]   pinentry-tty

Comment 1 Kristian Fiskerstrand (RETIRED) gentoo-dev

2017-07-19 16:54:38 UTC

can you (i) check that -qt4 isn't actually just a symlink to the qt5 build (ii) reproduce this with 1.0.0?

Comment 2 Mircea Sava 2017-07-20 11:36:35 UTC

(i) Indeed, just a symlink to the qt5 binary and I understand why that might be necessary.
(ii) Same thing with v1.0.0

Comment 3 Kristian Fiskerstrand (RETIRED) gentoo-dev

2017-07-20 11:50:03 UTC

(In reply to Mircea Sava from comment #2)
> (i) Indeed, just a symlink to the qt5 binary and I understand why that might
> be necessary.

yeah, iirc we kept this around when upstream changed name from -qt4 to the agnostic -qt , otherwise the eselect would flip from qt to a non-qt variant that is earlier in the preference list on upgrade.

> (ii) Same thing with v1.0.0
yup


anyhow, nothing to do, so closing