Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 625516 - update dev-ruby/trollop ruby targets
Summary: update dev-ruby/trollop ruby targets
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-18 14:08 UTC by tao
Modified: 2017-07-21 16:59 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Add recent ruby targets (trollop-update_ruby_targets.patch,417 bytes, patch)
2017-07-18 14:08 UTC, tao
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description tao 2017-07-18 14:08:36 UTC
Created attachment 485392 [details, diff]
Add recent ruby targets

Trollop builds just fine with recent Ruby: https://github.com/ManageIQ/trollop/commit/e073910e227632671827efea642fe0ade560caf4#diff-354f30a63fb0907d4ad57269548329e3

OTOH ruby20 target is already deprecated https://wiki.gentoo.org/wiki/Project:Ruby
Comment 1 Hans de Graaff gentoo-dev Security 2017-07-19 06:29:23 UTC
The commit you reference is not in a released version.

Tests fail for trollop-1.2.1 with both ruby23 and ruby24, as documented in the ebuild.

The best course of action here is to lobby upstream to release a new version.
Comment 2 tao 2017-07-19 12:15:30 UTC
Well…

---8<------------8<------------8<------------8<------------8<------------8<-----
$ rake test

Run options: --seed 65056

# Running:

.....................................................................Use assert_nil if expecting nil from /trollop/test/trollop/parser_test.rb:393:in `test_short_options_combine'. This will fail in MT6.
Use assert_nil if expecting nil from /trollop/test/trollop/parser_test.rb:398:in `test_short_options_combine'. This will fail in MT6.
......................................................

Finished in 0.136530s, 900.9009 runs/s, 3259.3569 assertions/s.

123 runs, 445 assertions, 0 failures, 0 errors, 0 skips
---8<------------8<------------8<------------8<------------8<------------8<-----

The comment you reference is vague.

I do not know about ruby23, but tests are passing with ruby24. Nb. tests require chronic gem to be installed to pass. I guess that with chronic ruby23 will pass too.
Comment 3 Hans de Graaff gentoo-dev Security 2017-07-21 16:59:46 UTC
(In reply to tao from comment #2)
> Nb. tests
> require chronic gem to be installed to pass. I guess that with chronic
> ruby23 will pass too.

Thanks for that hint. I completely missed that since the errors did not mention chronic at all. ruby23 and ruby24 now added.