Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 62543 - mkvtoolnix: gtk use flags wrongly handled in 0.9.5 ebuild
Summary: mkvtoolnix: gtk use flags wrongly handled in 0.9.5 ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo wxWidgets project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-01 12:10 UTC by Michael Rolf
Modified: 2004-12-07 11:31 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Rolf 2004-09-01 12:10:50 UTC
The wxWindows/wxWidget support of mkvtoolnix is optional but the 0.9.5 ebuild handle it as a mandatory requirement.
Up to 0.9.3 I always installed the console only tools of the package with no problems, but after an Update to 0.9.5 I got an failure during the emerge because of missing wx-Files.


Reproducible: Always
Steps to Reproduce:
1. No wxWindows/wxWidget installed
2. env USE="-X -gtk -gtk2" emerge mkvtoolnix
3.

Actual Results:  
emerge failed 

Expected Results:  
the console only tools of mkvtoolnix should be emerged successfully 

I changed the src_compile() function to the following code to get a working 
ebuild: 
src_compile() { 
        if use gtk2 ; then 
                need-wxwidgets gtk2 
        elif use gtk ; then 
                need-wxwidgets gtk 
        fi 
        ./configure || die "configure died" 
        emake || die "make failed" 
}
Comment 1 Rob Cakebread (RETIRED) gentoo-dev 2004-09-01 15:14:09 UTC
I think the 'X' USE flag should determine if it compiles the GUI. If so, then use either gtk2 or -gtk2 version of wxWidgets:

	if use X ; then
		if ! use gtk2 ; then
			need-wxwidgets gtk
		else
			need-wxwidgets gtk2
		fi
	fi

media-video herd, what do you think?

Comment 2 Martin Holzer (RETIRED) gentoo-dev 2004-09-02 04:41:12 UTC
how about making a new global use flag call "GUI" ?
Comment 3 Michael Rolf 2004-09-02 11:54:19 UTC
I think the solution in comment #1 looks better than my solution.

Is a general GUI use flag a little to common?
What belongs to this GUI flag? X-Windows, the framebuffer, a LED Display in then PC, or ...?
Comment 4 Martin Holzer (RETIRED) gentoo-dev 2004-12-07 11:31:47 UTC
-r1 fixes this