Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 624436 - dev-libs/sink-0.3.0: enable BUILD_DAV
Summary: dev-libs/sink-0.3.0: enable BUILD_DAV
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
: 628320 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-07-10 12:45 UTC by Perfect Gentleman
Modified: 2017-08-19 20:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
sink-0.3.0.ebuild (sink-0.3.0.ebuild,780 bytes, text/plain)
2017-07-11 03:50 UTC, Perfect Gentleman
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Perfect Gentleman 2017-07-10 12:45:07 UTC
enable BUILD_DAV
Comment 1 Andreas Sturmlechner gentoo-dev 2017-07-10 18:04:15 UTC
Care to write a proper sentence?
Comment 2 Perfect Gentleman 2017-07-11 03:49:31 UTC
current ebuild doesn't respect default options set in CMakeFile, i.e.
-------
option(BUILD_MAILDIR "BUILD_MAILDIR" ON)
option(BUILD_DAV "BUILD_DAV" ON)
-------
as they are defined in examples directory, which is disabled in kde5.eclass
Comment 3 Perfect Gentleman 2017-07-11 03:50:31 UTC
Created attachment 482968 [details]
sink-0.3.0.ebuild

modified ebuild with kimap2 & kdav2 support
Comment 4 Andreas Sturmlechner gentoo-dev 2017-08-19 15:32:33 UTC
You are changing multiple unrelated lines compared to 0.3.0. Please explain why, and in the future submit unified diff instead of a full ebuild so we can review your changes right away.

If the goal of your ebuild is to enable BUILD_DAV I don't see your ebuild do that anywhere (missing src_configure).
Comment 5 Andreas Sturmlechner gentoo-dev 2017-08-19 15:44:56 UTC
CMakeLists.txt says about examples subdir: # example implementations

So, does it actually add anything of value at runtime?
Comment 6 Perfect Gentleman 2017-08-19 16:36:25 UTC
(In reply to Andreas Sturmlechner from comment #5)
> CMakeLists.txt says about examples subdir: # example implementations
> 
> So, does it actually add anything of value at runtime?

yes, it does. this subdir contains sources for DAV
Comment 7 David Williams 2017-08-19 18:58:11 UTC
I can confirm that it does. The examples use flag pulls in
 * KIMAP2 (required version >= 0.2)
 * CURL (required version >= 7.20.0)
 * KPimKDAV2

as shown by the extracts of the configure logs shown below. More importantly the build of Kube now works instead of saying Disconnected all the time. 

It's a shame that the library wasn't tested for function as well as build. It's also a shame that time was wasted arguing about the new build rather than trying it out.

Without the examples use flag:

-- The following OPTIONAL packages have been found:

 * PkgConfig
 * Libgit2 (required version >= 0.20.0)
 * Qt5Test
 * Qt5Concurrent

-- The following REQUIRED packages have been found:

 * ECM (required version >= 1.0.0)
 * Qt5Core
 * Qt5Network
 * Qt5Gui
 * Qt5
 * KF5Contacts
 * FlatBuffers
 * KAsync
 * LMDB
 * KF5Mime
 * KF5
 * Readline

-- <<< Gentoo configuration >>>
Build type      Gentoo
Install path    /usr
Compiler flags:
C               -march=native -O2 -pipe
C++             -march=native -O2 -pipe
Linker flags:
Executable      -Wl,-O1 -Wl,--as-needed
Module          -Wl,-O1 -Wl,--as-needed
Shared          -Wl,-O1 -Wl,--as-needed

-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

and with the examples use flag.

-- The following OPTIONAL packages have been found:

 * PkgConfig
 * Libgit2 (required version >= 0.20.0)
 * Qt5Test
 * Qt5Concurrent

-- The following REQUIRED packages have been found:

 * ECM (required version >= 1.0.0)
 * Qt5Core
 * Qt5Network
 * Qt5Gui
 * Qt5
 * KF5Contacts
 * FlatBuffers
 * KAsync
 * LMDB
 * KIMAP2 (required version >= 0.2)
 * CURL (required version >= 7.20.0)
 * KPimKDAV2
 * KF5Mime
 * KF5
 * Readline

-- <<< Gentoo configuration >>>
Build type      Gentoo
Install path    /usr
Compiler flags:
C               -march=native -O2 -pipe
C++             -march=native -O2 -pipe
Linker flags:
Executable      -Wl,-O1 -Wl,--as-needed
Module          -Wl,-O1 -Wl,--as-needed
Shared          -Wl,-O1 -Wl,--as-needed

-- Configuring done
-- Generating done
CMake Warning:
  Manually-specified variables were not used by the project:

    BUILD_TESTING
Comment 8 Andreas Sturmlechner gentoo-dev 2017-08-19 19:29:41 UTC
(In reply to David Williams from comment #7)
> It's also a shame that time was wasted arguing about the new build rather
> than trying it out.
Yes, how dare one ask for more information before investing time in a feature request. And thanks for your (duplicate) bug with an actual proper error description.
Comment 9 Andreas Sturmlechner gentoo-dev 2017-08-19 19:29:52 UTC
*** Bug 628320 has been marked as a duplicate of this bug. ***
Comment 10 Andreas Sturmlechner gentoo-dev 2017-08-19 20:22:05 UTC
Thanks for your reports, fixed in git commit e0e7c1b084b748b4c84d65177fdce88645111aca