Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 623804 - app-text/xiphos-4.0.5 version bump
Summary: app-text/xiphos-4.0.5 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Theology Herd (disbanded)
URL:
Whiteboard:
Keywords:
Depends on: 623808
Blocks:
  Show dependency tree
 
Reported: 2017-07-04 15:15 UTC by tonemgub
Modified: 2017-08-27 16:31 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xiphos-4.0.5.ebuild (xiphos-4.0.5.ebuild,1.95 KB, text/plain)
2017-07-04 16:43 UTC, tonemgub
Details

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 tonemgub 2017-07-04 16:43:50 UTC
Created attachment 480636 [details]
xiphos-4.0.5.ebuild

Patch ready.

Depends on #623808 "-static".
Comment 2 Jonas Stein gentoo-dev 2017-07-04 20:14:47 UTC
I had a short look on the ebuild and suggest the following:
always bump to the latest EAPI
-> EAPI=6


add ~
KEYWORDS="~amd64"
(is there a reason why x86 is not listed?)


SRC_URI="https://github.com/crosswire/xiphos/releases/download/4.0.5/${MY_P}.tar.gz"
use a variable instead of 4.0.5

Do you really need these?
MY_PV="${PV}-20170423"
MY_P="${PN}-${MY_PV}"
Comment 3 Chris Reffett (RETIRED) gentoo-dev Security 2017-07-05 01:47:31 UTC
(In reply to Jonas Stein from comment #2)
> I had a short look on the ebuild and suggest the following:
> always bump to the latest EAPI
> -> EAPI=6
> 
Yup.
 
> add ~
> KEYWORDS="~amd64"
> (is there a reason why x86 is not listed?)
> 
Because I only run amd64 for dev work and nobody's asked for an x86 keyword yet.

> 
> SRC_URI="https://github.com/crosswire/xiphos/releases/download/4.0.5/${MY_P}.
> tar.gz"
> use a variable instead of 4.0.5
> 
Yup.

> Do you really need these?
> MY_PV="${PV}-20170423"
> MY_P="${PN}-${MY_PV}"
It's better than putting a magic string into SRC_URI and having to remember to change it every time they bump (since upstream likes tagging the tarball with the date for whatever reason).

tonemgub: In the future, it's helpful to attach your changes as a diff so that I can easily see what changed in your ebuild. No need to do that now though, I'm working on the bump, it'll be a couple days depending on my availability and whether or not webkitgtk:4 actually works this time around.
Comment 4 Chris Reffett (RETIRED) gentoo-dev Security 2017-08-27 16:31:01 UTC
Since 4.0.6 claims to have fixed the webkitgtk4 issues, I've bumped to that. Closing.