Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 623660 - sys-fs/f2fs-tools-1.8.0 : ../.../libf2fs.so: undefined reference to `minor'
Summary: sys-fs/f2fs-tools-1.8.0 : ../.../libf2fs.so: undefined reference to `minor'
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-03 17:25 UTC by Toralf Förster
Modified: 2017-08-26 12:34 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,15.47 KB, text/plain)
2017-07-03 17:25 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,345.24 KB, text/plain)
2017-07-03 17:25 UTC, Toralf Förster
Details
environment (environment,15.65 KB, text/plain)
2017-07-03 17:25 UTC, Toralf Förster
Details
etc.portage.tbz2 (etc.portage.tbz2,26.99 KB, application/x-bzip)
2017-07-03 17:25 UTC, Toralf Förster
Details
logs.tbz2 (logs.tbz2,8.55 KB, application/x-bzip)
2017-07-03 17:26 UTC, Toralf Förster
Details
sys-fs:f2fs-tools-1.8.0:20170703-021607.log (sys-fs:f2fs-tools-1.8.0:20170703-021607.log,15.59 KB, text/plain)
2017-07-03 17:26 UTC, Toralf Förster
Details
temp.tbz2 (temp.tbz2,8.90 KB, application/x-bzip)
2017-07-03 17:26 UTC, Toralf Förster
Details
Patch for libf2fs.c (libf2fs-sysmacros.patch,324 bytes, patch)
2017-08-16 20:09 UTC, AlexOmskiy
Details | Diff
New 1.6.0 ebuild with patch for #580338 & #623660 (f2fs-tools-1.6.0.ebuild,798 bytes, text/plain)
2017-08-16 20:12 UTC, AlexOmskiy
Details
New 1.6.1 ebuild with patch for #623660 (f2fs-tools-1.6.1.ebuild,791 bytes, text/plain)
2017-08-16 20:13 UTC, AlexOmskiy
Details
New 1.8.0 ebuild with patch for #623660 (f2fs-tools-1.8.0.ebuild,785 bytes, text/plain)
2017-08-16 20:14 UTC, AlexOmskiy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2017-07-03 17:25:46 UTC
/bin/sh ../libtool  --tag=CC   --mode=link x86_64-pc-linux-gnu-gcc -Wall -DWITH_BLKDISCARD -O2 -pipe -march=native -Wall  -Wl,-O1 -Wl,--as-needed -o mkfs.f2fs f2fs_format_main.o f2fs_format.o f2fs_format_utils.o -luuid  ../lib/libf2fs.la 
libtool: link: x86_64-pc-linux-gnu-gcc -Wall -DWITH_BLKDISCARD -O2 -pipe -march=native -Wall -Wl,-O1 -Wl,--as-needed -o .libs/mkfs.f2fs f2fs_format_main.o f2fs_format.o f2fs_format_utils.o  -luuid ../lib/.libs/libf2fs.so
../lib/.libs/libf2fs.so: undefined reference to `minor'

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 13.0-systemd_20170625-200344

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-6.3.0 *

Available Python interpreters, in order of preference:
  [1]   python3.4
  [2]   python3.5 (fallback)
  [3]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby21 (with Rubygems) *
  [2]   ruby22 (with Rubygems)
java-config:
The following VMs are available for generation-2:
Comment 1 Toralf Förster gentoo-dev 2017-07-03 17:25:50 UTC
Created attachment 480140 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2017-07-03 17:25:53 UTC
Created attachment 480142 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2017-07-03 17:25:56 UTC
Created attachment 480144 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2017-07-03 17:25:59 UTC
Created attachment 480146 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2017-07-03 17:26:02 UTC
Created attachment 480148 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2017-07-03 17:26:05 UTC
Created attachment 480150 [details]
sys-fs:f2fs-tools-1.8.0:20170703-021607.log
Comment 7 Toralf Förster gentoo-dev 2017-07-03 17:26:09 UTC
Created attachment 480152 [details]
temp.tbz2
Comment 8 Bigos 2017-08-16 18:08:36 UTC
It seems that the lib/libf2fs.c file lacks the following include:

#include <sys/sysmacros.h>

After adding it manually, the build finished successfully for me.

The reason it fails might be due to a difference in glibc version (i.e. previously sys/sysmacros.h was included indirectly somewhere). Either way, it's a bug in libf2fs.
Comment 9 AlexOmskiy 2017-08-16 20:06:02 UTC
(In reply to Bigos from comment #8)
> It seems that the lib/libf2fs.c file lacks the following include:
> 
> #include <sys/sysmacros.h>
> 
> After adding it manually, the build finished successfully for me.
> 
> The reason it fails might be due to a difference in glibc version (i.e.
> previously sys/sysmacros.h was included indirectly somewhere). Either way,
> it's a bug in libf2fs.

Thank you
May be it's gentoo glibc bug with sys-types.h-drop-sys-sysmacros.h-include.patch ?
glibc-2.24
00_all_0028-sys-types.h-drop-sys-sysmacros.h-include.patch
00_all_0045-Revert-sys-types.h-drop-sys-sysmacros.h-include.patch
glibc-2.25
00_all_0005-sys-types.h-drop-sys-sysmacros.h-include.patch

For sys-libs/glibc-2.25-r2/-r3 build fine only f2fs-tools-1.7.0-r2 with sys-libs/libselinux & sys-libs/libsepol deps.
Comment 10 AlexOmskiy 2017-08-16 20:09:00 UTC
Created attachment 489352 [details, diff]
Patch for libf2fs.c
Comment 11 AlexOmskiy 2017-08-16 20:12:33 UTC
Created attachment 489354 [details]
New 1.6.0 ebuild with patch for #580338 & #623660
Comment 12 AlexOmskiy 2017-08-16 20:13:54 UTC
Created attachment 489356 [details]
New 1.6.1 ebuild with patch for #623660
Comment 13 AlexOmskiy 2017-08-16 20:14:47 UTC
Created attachment 489358 [details]
New 1.8.0 ebuild with patch for #623660
Comment 14 dB 2017-08-22 01:55:19 UTC
I still have this issue with output as follows:

../lib/.libs/libf2fs.so: undefined reference to `minor'
../lib/.libs/libf2fs.so: undefined reference to `major'
collect2: error: ld returned 1 exit status

Is this related to this bug?
Comment 15 Anthony Basile gentoo-dev 2017-08-22 03:27:35 UTC
(In reply to dB from comment #14)
> I still have this issue with output as follows:
> 
> ../lib/.libs/libf2fs.so: undefined reference to `minor'
> ../lib/.libs/libf2fs.so: undefined reference to `major'
> collect2: error: ld returned 1 exit status
> 
> Is this related to this bug?

yes.  i'll try to take care of it today.
Comment 16 Anthony Basile gentoo-dev 2017-08-22 05:33:04 UTC
please test version 1.8.0 and report back
Comment 17 Anthony Basile gentoo-dev 2017-08-26 12:34:53 UTC
(In reply to Anthony Basile from comment #16)
> please test version 1.8.0 and report back

okay no complaints.  reopen if it still a problem though i can't see how.