Bug 623652 – [vmware-overlay] app-emulation/vmware-modules-308.5.7 patch for kernel-4.12.0

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Harris Landgarten 2017-07-03 16:07:19 UTC]

Created attachment 480110 [details, diff]
vmblock patch

kernel-4.12.0 removed include/linux/time.h which contains a DEFINE CURRENT_TIME macro

vmblock referenced that macro and no longer builds.

I attached a small patch that changes the reference to CURRENT_TIME to its actual definition. This should work on other kernels as well.

[Comment 1 Fabio Rossi 2017-07-04 22:35:39 UTC]

Thanks but the patch is not complete, doesn't consider the case USE="vmci". 

The file vmci-only/linux/driver.c needs a backport of linux commit 3bb434cdcc6af3d4e70ba041e6f596e465d11e14

[Comment 2 Harris Landgarten 2017-07-05 00:04:05 UTC]

I use vmci and vsock from kernel. Is there a good reason not to do this at this point.

[Comment 3 O. William McClung 2017-07-05 22:20:16 UTC]

I can confirm that the patch worked with vmware-modules-308.5.7::vmware and kernel 4.12.0, ~amd64.

[Comment 4 Manfred Knick 2017-07-08 12:43:22 UTC]

Downloaded Harris' vmblock patch into my local overlay as

. . . "vmware-modules/files/308-4.12-00-vmblock.patch"

and added it to copy-renamed 

. . . vmware-modules-308.5.7-r1.ebuild :

> kernel_is ge 4 12 0 && epatch "${FILESDIR}/${PV_MAJOR}-4.12-00-vmblock.patch"

CONFIRMATION :
As expected, all usual quick tests succeeded for 4.12.0 / "amd64" as well.

@ Harris: Thanks!

(In reply to Harris Landgarten from comment #2)
> I use vmci and vsock from kernel. 
> Is there a good reason not to do this at this point.
I did not stumble across any;
also only USE="-vmci -vsock"  'since ages'.

[Comment 5 Manfred Knick 2017-07-08 12:46:01 UTC]

Created attachment 482022 [details, diff]
vmware-modules-308.5.7-r1.ebuild.diff    (

diff -Naur 
   vmware-modules/vmware-modules-308.5.7.ebuild
   vmware-modules/vmware-modules-308.5.7-r1.ebuild
 > vmware-modules-308.5.7-r1.ebuild.diff

[Comment 6 Manfred Knick 2017-07-08 13:34:47 UTC]

(supplementing comment #4)

A diligent but routine piece of work: 
Backward compatibility test for latest stable longterm:

  re-emerge
    - app-emulation/vmware-workstation
    - app-emulation/vmware-modules
    - app-emulation/vmware-tools

CONFIRMATION :

As expected, all usual quick tests succeeded 
- for 4.9.35-gentoo / "amd64"       and
- for 4.9.36-gentoo / "amd64"
as well.

[Comment 7 Manfred Knick 2017-08-26 08:22:13 UTC]

REFERENCE:

https://bugs.gentoo.org/show_bug.cgi?id=619392#c2

[Comment 8 Fabio Rossi 2017-11-09 22:06:40 UTC]

the overlay is now updated up to kernel 4.14-rcX