Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 62316 - arts-1.3.0 won't build anymore
Summary: arts-1.3.0 won't build anymore
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High major (vote)
Assignee: Gentoo KDE team
URL:
Whiteboard:
Keywords:
: 62470 62593 62596 (view as bug list)
Depends on:
Blocks:
 
Reported: 2004-08-30 17:05 UTC by Stefan Briesenick (RETIRED)
Modified: 2004-09-02 05:31 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Briesenick (RETIRED) gentoo-dev 2004-08-30 17:05:19 UTC
well, I emerged KDE 3.3 on 3 of my machines as an update to KDE 3.2.3. No problems!

Then I tried to emerge it on a system w/o KDE installed. It's broken (error output follows). Ok, maybe a problem on this particular machine... So I tried to re-emerge arts on one of the other previosly installed machines. But now, old KDE 3.2.3 is removed.

Result:

Calculating dependencies ...done!
>>> emerge (1 of 1) kde-base/arts-1.3.0 to /
>>> md5 src_uri ;-) arts-1.3.0.tar.bz2
>>> Unpacking source...
>>> Unpacking arts-1.3.0.tar.bz2 to /vol1/gentoo/build/portage/arts-1.3.0/work
Running sed on Makefile.am
Running sed on Makefile.in
 * Applying 1.3.0-jack-configure.in.in.patch...

 * Failed Patch: 1.3.0-jack-configure.in.in.patch!
 *
 * Include in your bugreport the contents of:
 *
 *   /vol1/gentoo/build/portage/arts-1.3.0/temp/1.3.0-jack-configure.in.in.patch-5010.out


!!! ERROR: kde-base/arts-1.3.0 failed.
!!! Function epatch, Line 341, Exitcode 0
!!! Failed Patch: 1.3.0-jack-configure.in.in.patch!


[1.3.0-jack-configure.in.in.patch-5010.out]

***** 1.3.0-jack-configure.in.in.patch *****

============================================

PATCH COMMAND:  patch -p0 -g0 < /mnt/gentoo/usr/portage/kde-base/arts/files/1.3.0-jack-configure.in.in.patch

============================================
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- /var/tmp/portage/arts-1.3.0/work/arts-1.3.0/configure.in.in        2004-08-05 13:53:14.000000000 -0500
|+++ configure.in.in    2004-08-26 14:15:51.901070600 -0500
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
============================================

PATCH COMMAND:  patch -p1 -g0 < /mnt/gentoo/usr/portage/kde-base/arts/files/1.3.0-jack-configure.in.in.patch

============================================
missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- /var/tmp/portage/arts-1.3.0/work/arts-1.3.0/configure.in.in        2004-08-05 13:53:14.000000000 -0500
|+++ configure.in.in    2004-08-26 14:15:51.901070600 -0500
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
============================================

PATCH COMMAND:  patch -p2 -g0 < /mnt/gentoo/usr/portage/kde-base/arts/files/1.3.0-jack-configure.in.in.patch

============================================
missing header for unified diff at line 3 of patch
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- /var/tmp/portage/arts-1.3.0/work/arts-1.3.0/configure.in.in        2004-08-05 13:53:14.000000000 -0500
|+++ configure.in.in    2004-08-26 14:15:51.901070600 -0500
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
============================================

PATCH COMMAND:  patch -p3 -g0 < /mnt/gentoo/usr/portage/kde-base/arts/files/1.3.0-jack-configure.in.in.patch

============================================


STRANGE!


Reproducible: Always
Steps to Reproduce:
Comment 1 Caleb Tennis (RETIRED) gentoo-dev 2004-08-31 05:58:07 UTC
The patch applies just fine here.  Most likely you've downloaded a corrupted patch or a bad tarball.  Just resync and try again later.
Comment 2 Stefan Briesenick (RETIRED) gentoo-dev 2004-08-31 07:22:34 UTC
no. I sync'ed 3 times. 

But when I comment out the 'epatch' line, it works perfectly. And ldd shows, that jack is linked. So why do we need this epatch?
Comment 3 Stefan Briesenick (RETIRED) gentoo-dev 2004-08-31 07:25:59 UTC
ok, I'm @ work now. So I tested to re-emerge 'arts' on my PC @ work right now.

SAME PROBLEM!
Comment 4 Stefan Briesenick (RETIRED) gentoo-dev 2004-08-31 07:28:11 UTC
here the md5sums:

c92fbc7f2381271c696b8dceae3de0cb  arts-1.3.0.ebuild
afbe195b431271c6ccfe51cc58aced5c  files/digest-arts-1.3.0
19c3132f3745df60d80211f36e4ae31d  files/1.3.0-jack-configure.in.in.patch
Comment 5 Caleb Tennis (RETIRED) gentoo-dev 2004-08-31 07:32:02 UTC
I see the problem - you're using a non-traditional portdir in this setup, and the patch had the directory hardcoded.

I just fixed the patch - resync a little bit later and see if that doesn't fix it for you.
Comment 6 Stefan Briesenick (RETIRED) gentoo-dev 2004-08-31 10:38:06 UTC
well, I try to save bandwidth ;-) It's on my NFS-Server or at least on a bigger partition. But I have symlinks to the original places.

But hardcoded links are always a very bad idea!

nonetheless, the ebuild works perfectly w/o the epatch. And yes, I have 'jack' in my USE-Flags and it is linked after emerge (at least 'ldd' says that). So why do we need this patch at all?
Comment 7 Caleb Tennis (RETIRED) gentoo-dev 2004-08-31 11:30:44 UTC
The hardcoded link was unintentional.

The patch is there because there's no way to turn jack on or off - it's on if arts and find it and off it if can't.  This patch allows you to turn it off even if you already have jack on your machine.
Comment 8 Stefan Briesenick (RETIRED) gentoo-dev 2004-08-31 13:00:15 UTC
> This patch allows you to turn it off even if you 
> already have jack on your machine.

accepted! Oh, those stupid configure-scripts. ;-)

Yes, I know them. For 5 options you can use enable/disable correctly and for 3 other options you can use it, but if the auto-detect finds it, it's always enabled. Grmpf!

Ok, I test if your fix works. I'm syncing right now and give feedback in some minutes.
Comment 9 Stefan Briesenick (RETIRED) gentoo-dev 2004-08-31 13:05:09 UTC
!!! ERROR: kde-base/arts-1.3.0 failed.
!!! Function epatch, Line 362, Exitcode 0
!!! Failed Patch: 1.3.0-jack-configure.in.in.patch!

***** 1.3.0-jack-configure.in.in.patch *****

============================================

PATCH COMMAND:  patch -p0 -g0 < /mnt/gentoo/usr/portage/kde-base/arts/files/1.3.0-jack-configure.in.in.patch

============================================
can't find file to patch at input line 3
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|--- configure.in.in    2004-08-05 13:53:14.000000000 -0500
|+++ configure.in.in    2004-08-26 14:15:51.901070600 -0500
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
============================================
[..]


Ok, I try to fix it for myself and post a working ebuild.
Comment 10 Stefan Briesenick (RETIRED) gentoo-dev 2004-08-31 13:08:37 UTC
HMPF!!!!!!! :-D

put the epatch behind the "cd" and it works.

src_unpack() {
    kde_src_unpack
    kde_sandbox_patch ${S}/soundserver
    # for the configure.in.in patch, for some reason it's not automatically picked up
    # rm -f $S/configure

    epatch ${FILESDIR}/1.3.0-jack-configure.in.in.patch

    cd ${S} && make -f admin/Makefile.common
    # use amd64 && epatch ${FILESDIR}/arts-${PV}-buffer.patch
    # this patch fixes the high cpu usage of mp3 and vorbis
    # epatch ${FILESDIR}/arts-vorbis-fix.dif
}


change it to:

[..]
    cd ${S}
    epatch ${FILESDIR}/1.3.0-jack-configure.in.in.patch
    make -f admin/Makefile.common
[..]
Comment 11 Caleb Tennis (RETIRED) gentoo-dev 2004-09-01 06:01:16 UTC
*** Bug 62470 has been marked as a duplicate of this bug. ***
Comment 12 Caleb Tennis (RETIRED) gentoo-dev 2004-09-01 06:07:28 UTC
Changed the ebuild order around a little bit - please let me know if this fixes it for you.
Comment 13 Stefan Briesenick (RETIRED) gentoo-dev 2004-09-01 12:44:54 UTC
ok, latest fixes seems to work.
but you should mark it as *-r1.
Comment 14 Caleb Tennis (RETIRED) gentoo-dev 2004-09-01 13:23:40 UTC
not going to mark -r1, it adds no real new functionality.
Comment 15 Caleb Tennis (RETIRED) gentoo-dev 2004-09-02 05:30:57 UTC
*** Bug 62593 has been marked as a duplicate of this bug. ***
Comment 16 Caleb Tennis (RETIRED) gentoo-dev 2004-09-02 05:31:56 UTC
*** Bug 62596 has been marked as a duplicate of this bug. ***