Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 623022 - media-gfx/kuickshow - Restore package
Summary: media-gfx/kuickshow - Restore package
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christian Gerloff
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-29 13:09 UTC by Christian Gerloff
Modified: 2017-07-18 21:25 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
proposed patch (gcc6-compile-fix.patch,408 bytes, patch)
2017-06-29 13:09 UTC, Christian Gerloff
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Christian Gerloff 2017-06-29 13:09:53 UTC
Created attachment 478334 [details, diff]
proposed patch

The package has been removed from gentoo with commit cdc9ca1ad230f429babfeae7e5d9d8f44068e2e0 because of bug #614304 (which I found only after it was already too late).

That bug was easy to fix and I have a patch for it.
Since I use kuickshow fairly often, I'm willing to maintain the package.

I've attached the patch here and will provide a PR on GitHub for the updated ebuild shortly.
Comment 1 Michael Palimaka (kensington) gentoo-dev 2017-06-29 13:14:25 UTC
Noting that GCC 6 build failure was just one reason, it was also completely dead upstream with no Qt 5 port in site.
Comment 2 Christian Gerloff 2017-06-29 13:35:25 UTC
That's true. I haven't found a link to a working repository when I was looking for the "official" source code. I had to use the tarball downloaded by portage.

I'm currently looking into how much work it would be to port this to KDE5 (it uses some KDE4 classes).
If that works I'd put it on GitHub as well.
Comment 3 Michael Palimaka (kensington) gentoo-dev 2017-06-29 13:36:48 UTC
Good luck! I miss kuickshow too - I always preferred it over the others.
Comment 4 Christian Gerloff 2017-06-29 15:53:57 UTC
I've created a PR on GitHub (https://github.com/gentoo/gentoo/pull/5012) with 2 commits:
1) A revert of the package removal
2) The patch to fix the compile issue and an updated ebuild

The source tarball is no longer on the Gentoo mirrors, but I still have a copy (dated 2010-02-12).
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-07-18 21:25:14 UTC
commit 904008cf9f669202e0bbc7ddc30c2eaf2c3647ac (HEAD -> master, origin/master, origin/HEAD)
Author:     Christian Gerloff <chrgerloff@gmx.net>
AuthorDate: Wed Jul 5 15:47:07 2017
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: Tue Jul 18 23:23:51 2017

    media-gfx/kuickshow: Restore package
    
    Include a patch to fix a compile error with GCC 6.
    
    Also update ebuild to EAPI 6, mark the package as unstable,
    and change download url and maintainer.
    
    Closes: https://github.com/gentoo/gentoo/pull/5012
    Package-Manager: Portage-2.3.6, Repoman-2.3.1