Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 622814 - app-office/libreoffice-5.3.4.2 needs stable media-libs/libgltf-0.0.2
Summary: app-office/libreoffice-5.3.4.2 needs stable media-libs/libgltf-0.0.2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Office Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-27 11:36 UTC by Ulenrich
Modified: 2017-06-27 19:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
libreoffice-5.3.4.2-lbgltf-0.1.patch enables new libgltf (libreoffice-5.3.4.2-lbgltf-0.1.patch,2.65 KB, patch)
2017-06-27 15:13 UTC, Ulenrich
Details | Diff
libreoffice-5.3.4.2-r1.diff (libreoffice-5.3.4.2-r1.diff,583 bytes, patch)
2017-06-27 15:29 UTC, Ulenrich
Details | Diff
complete upstream patch modified to work (openldap_des_change_complete-dwok.diff,5.81 KB, patch)
2017-06-27 19:41 UTC, Attila Tóth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulenrich 2017-06-27 11:36:01 UTC
while compiling libreoffice and having activated USE-flag gltf
in
work/libreoffice-5.3.4.2/configure 
will test:
$PKG_CONFIG --exists --print-errors "libgltf-0.0 >= 0.0.1

and 
work/libreoffice-5.3.4.2/download.lst 
shows
export LIBGLTF_TARBALL := libgltf-0.0.2.tar.bz2

configure fails having installed newest media-libs/libgltf-0.1.0 
thus depends must be versionized
Comment 1 Andreas Sturmlechner gentoo-dev 2017-06-27 11:54:47 UTC
Could you please test the following patch over lo-5.3.4.2 (requires libepoxy as new dependency)?

https://cgit.freedesktop.org/libreoffice/core/commit/configure.ac?id=482d7ce61b423600b41b459eb26a2cc221cd0acf
Comment 2 Ulenrich 2017-06-27 15:13:49 UTC
Created attachment 478232 [details, diff]
libreoffice-5.3.4.2-lbgltf-0.1.patch enables new libgltf

Now
configure phase succeeds with above patch applied:
---
checking whether to enable glTF support... yes
checking for libgltf-0.1 >= 0.1.0 ... yes
checking whether to enable COLLADA support... yes
checking which OPENCOLLADA to use... external
checking COLLADABU.h usability... yes
checking COLLADABU.h presence... yes
checking for COLLADABU.h... yes
checking COLLADAFW.h usability... yes
checking COLLADAFW.h presence... yes
checking for COLLADAFW.h... yes
checking COLLADASaxFWLLoader.h usability... yes
checking COLLADASaxFWLLoader.h presence... yes
checking for COLLADASaxFWLLoader.h... yes
---
... My old 2009 mac-mini needs some hours 
to fully compile libreoffice ...
Comment 3 Ulenrich 2017-06-27 15:29:58 UTC
Created attachment 478234 [details, diff]
libreoffice-5.3.4.2-r1.diff

ebuild diff 
- enable libepoxy when USE gltf
- includes line with libreoffice-5.3.4.2-lbgltf-0.1.patch

I did test configure without the libepoxy line in the ebuild, because I had it @world and I am unsure if that line is correct.
I guess an -r1 revision is not needed, because everyone tried gltf/opencollada must have failed
Comment 4 Andreas Sturmlechner gentoo-dev 2017-06-27 16:59:06 UTC
Sorry, didn't realise the patch was much too big (it is more than just configure.ac), so I pinned down dependency for <=5.3.9999 to libgltf-0.0* in git commit 195cd95f931f552afe628263084704bccde34cba.

Thanks for your report.
Comment 5 Attila Tóth 2017-06-27 19:41:16 UTC
Created attachment 478250 [details, diff]
complete upstream patch modified to work

Note, that only two trivial changes were necessary to let the complete upstream patch apply cleanly on 5.3.4.2. This also replaces glew with libepoxy.