Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 62281 - 001_ppc_drm-ioremap-agp.patch fails in x11-drm-20040827
Summary: 001_ppc_drm-ioremap-agp.patch fails in x11-drm-20040827
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC Linux
: High critical (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-30 11:47 UTC by Fernando Usero
Modified: 2005-10-12 19:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fernando Usero 2004-08-30 11:47:07 UTC
i've been told to paste here the contents of /var/tmp/portage/x11-drm-20040827/temp/001_ppc_drm-ioremap-agp.patch-11427.out:

***** 001_ppc_drm-ioremap-agp.patch *****

=========================================

PATCH COMMAND:  patch -p0 -g0 < /var/tmp/portage/x11-drm-20040827/work/patch/001_ppc_drm-ioremap-agp.patch

=========================================
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drmP.h drm/drmP.h
|--- drm-orig/drmP.h    2004-07-05 22:27:33.976066120 -0400
|+++ drm/drmP.h 2004-07-05 22:27:42.269805280 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 38
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_agpsupport.h drm/drm_agpsupport.h
|--- drm-orig/drm_agpsupport.h  2004-07-05 22:27:33.976066120 -0400
|+++ drm/drm_agpsupport.h       2004-07-05 22:27:42.269805280 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 52
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_memory.h drm/drm_memory.h
|--- drm-orig/drm_memory.h      2004-07-05 22:27:33.977065968 -0400
|+++ drm/drm_memory.h   2004-07-05 22:27:42.270805128 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 126
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_memory_debug.h drm/drm_memory_debug.h
|--- drm-orig/drm_memory_debug.h        2004-07-05 22:27:33.977065968 -0400
|+++ drm/drm_memory_debug.h     2004-07-05 22:27:42.270805128 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 235
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/r128_cce.c drm/r128_cce.c
|--- drm-orig/r128_cce.c        2004-07-05 22:27:34.003062016 -0400
|+++ drm/r128_cce.c     2004-07-05 22:27:42.271804976 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 276
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/radeon_cp.c drm/radeon_cp.c
|--- drm-orig/radeon_cp.c       2004-07-05 22:27:34.004061864 -0400
|+++ drm/radeon_cp.c    2004-07-05 22:27:42.274804520 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
=========================================

PATCH COMMAND:  patch -p1 -g0 < /var/tmp/portage/x11-drm-20040827/work/patch/001_ppc_drm-ioremap-agp.patch

=========================================
patching file drmP.h
Hunk #1 succeeded at 344 with fuzz 2 (offset -10 lines).
Hunk #2 FAILED at 877.
1 out of 2 hunks FAILED -- saving rejects to file drmP.h.rej
patching file drm_agpsupport.h
Hunk #1 succeeded at 108 (offset -2 lines).
patching file drm_memory.h
patching file drm_memory_debug.h
Hunk #1 succeeded at 456 (offset -1 lines).
patching file r128_cce.c
Hunk #1 FAILED at 513.
Hunk #2 FAILED at 606.
2 out of 2 hunks FAILED -- saving rejects to file r128_cce.c.rej
patching file radeon_cp.c
Hunk #1 FAILED at 1163.
Hunk #2 FAILED at 1294.
2 out of 2 hunks FAILED -- saving rejects to file radeon_cp.c.rej
=========================================

PATCH COMMAND:  patch -p2 -g0 < /var/tmp/portage/x11-drm-20040827/work/patch/001_ppc_drm-ioremap-agp.patch

=========================================
missing header for unified diff at line 4 of patch
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drmP.h drm/drmP.h
|--- drm-orig/drmP.h    2004-07-05 22:27:33.976066120 -0400
|+++ drm/drmP.h 2004-07-05 22:27:42.269805280 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
missing header for unified diff at line 38 of patch
can't find file to patch at input line 38
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_agpsupport.h drm/drm_agpsupport.h
|--- drm-orig/drm_agpsupport.h  2004-07-05 22:27:33.976066120 -0400
|+++ drm/drm_agpsupport.h       2004-07-05 22:27:42.269805280 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 52 of patch
can't find file to patch at input line 52
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_memory.h drm/drm_memory.h
|--- drm-orig/drm_memory.h      2004-07-05 22:27:33.977065968 -0400
|+++ drm/drm_memory.h   2004-07-05 22:27:42.270805128 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 126 of patch
can't find file to patch at input line 126
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_memory_debug.h drm/drm_memory_debug.h
|--- drm-orig/drm_memory_debug.h        2004-07-05 22:27:33.977065968 -0400
|+++ drm/drm_memory_debug.h     2004-07-05 22:27:42.270805128 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 235 of patch
can't find file to patch at input line 235
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/r128_cce.c drm/r128_cce.c
|--- drm-orig/r128_cce.c        2004-07-05 22:27:34.003062016 -0400
|+++ drm/r128_cce.c     2004-07-05 22:27:42.271804976 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
missing header for unified diff at line 276 of patch
can't find file to patch at input line 276
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/radeon_cp.c drm/radeon_cp.c
|--- drm-orig/radeon_cp.c       2004-07-05 22:27:34.004061864 -0400
|+++ drm/radeon_cp.c    2004-07-05 22:27:42.274804520 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
=========================================

PATCH COMMAND:  patch -p3 -g0 < /var/tmp/portage/x11-drm-20040827/work/patch/001_ppc_drm-ioremap-agp.patch

=========================================
missing header for unified diff at line 4 of patch
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drmP.h drm/drmP.h
|--- drm-orig/drmP.h    2004-07-05 22:27:33.976066120 -0400
|+++ drm/drmP.h 2004-07-05 22:27:42.269805280 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
missing header for unified diff at line 38 of patch
can't find file to patch at input line 38
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_agpsupport.h drm/drm_agpsupport.h
|--- drm-orig/drm_agpsupport.h  2004-07-05 22:27:33.976066120 -0400
|+++ drm/drm_agpsupport.h       2004-07-05 22:27:42.269805280 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 52 of patch
can't find file to patch at input line 52
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_memory.h drm/drm_memory.h
|--- drm-orig/drm_memory.h      2004-07-05 22:27:33.977065968 -0400
|+++ drm/drm_memory.h   2004-07-05 22:27:42.270805128 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 126 of patch
can't find file to patch at input line 126
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_memory_debug.h drm/drm_memory_debug.h
|--- drm-orig/drm_memory_debug.h        2004-07-05 22:27:33.977065968 -0400
|+++ drm/drm_memory_debug.h     2004-07-05 22:27:42.270805128 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 235 of patch
can't find file to patch at input line 235
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/r128_cce.c drm/r128_cce.c
|--- drm-orig/r128_cce.c        2004-07-05 22:27:34.003062016 -0400
|+++ drm/r128_cce.c     2004-07-05 22:27:42.271804976 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
missing header for unified diff at line 276 of patch
can't find file to patch at input line 276
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/radeon_cp.c drm/radeon_cp.c
|--- drm-orig/radeon_cp.c       2004-07-05 22:27:34.004061864 -0400
|+++ drm/radeon_cp.c    2004-07-05 22:27:42.274804520 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
=========================================

PATCH COMMAND:  patch -p4 -g0 < /var/tmp/portage/x11-drm-20040827/work/patch/001_ppc_drm-ioremap-agp.patch

=========================================
missing header for unified diff at line 4 of patch
can't find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drmP.h drm/drmP.h
|--- drm-orig/drmP.h    2004-07-05 22:27:33.976066120 -0400
|+++ drm/drmP.h 2004-07-05 22:27:42.269805280 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
missing header for unified diff at line 38 of patch
can't find file to patch at input line 38
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_agpsupport.h drm/drm_agpsupport.h
|--- drm-orig/drm_agpsupport.h  2004-07-05 22:27:33.976066120 -0400
|+++ drm/drm_agpsupport.h       2004-07-05 22:27:42.269805280 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 52 of patch
can't find file to patch at input line 52
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_memory.h drm/drm_memory.h
|--- drm-orig/drm_memory.h      2004-07-05 22:27:33.977065968 -0400
|+++ drm/drm_memory.h   2004-07-05 22:27:42.270805128 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 126 of patch
can't find file to patch at input line 126
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/drm_memory_debug.h drm/drm_memory_debug.h
|--- drm-orig/drm_memory_debug.h        2004-07-05 22:27:33.977065968 -0400
|+++ drm/drm_memory_debug.h     2004-07-05 22:27:42.270805128 -0400
--------------------------
No file to patch.  Skipping patch.
1 out of 1 hunk ignored
missing header for unified diff at line 235 of patch
can't find file to patch at input line 235
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/r128_cce.c drm/r128_cce.c
|--- drm-orig/r128_cce.c        2004-07-05 22:27:34.003062016 -0400
|+++ drm/r128_cce.c     2004-07-05 22:27:42.271804976 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored
missing header for unified diff at line 276 of patch
can't find file to patch at input line 276
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -urN drm-orig/radeon_cp.c drm/radeon_cp.c
|--- drm-orig/radeon_cp.c       2004-07-05 22:27:34.004061864 -0400
|+++ drm/radeon_cp.c    2004-07-05 22:27:42.274804520 -0400
--------------------------
No file to patch.  Skipping patch.
2 out of 2 hunks ignored



Reproducible: Always
Steps to Reproduce:
1.emerge x11-drm
2.
3.

Actual Results:  
broken compilation

Expected Results:  
merge x11-drm

Portage 2.0.50-r10 (default-ppc-2004.1, gcc-3.4.1, glibc-2.3.4.20040808-r0,
2.6.7-gentoo-r11)
=================================================================
System uname: 2.6.7-gentoo-r11 ppc 7455, altivec supported
Gentoo Base System version 1.5.3
distcc 2.17 powerpc-unknown-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
ccache version 2.3 [enabled]
Autoconf: sys-devel/autoconf-2.59-r4
Automake: sys-devel/automake-1.8.5-r1
ACCEPT_KEYWORDS="ppc ~ppc"
AUTOCLEAN="yes"
CFLAGS="-O2 -pipe -mcpu=7400 -maltivec -mabi=altivec -fno-strict-aliasing"
CHOST="powerpc-unknown-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /etc/tomcat /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3.1/share/config /usr/kde/3.2/share/config /usr/kde/3/share/config
/usr/lib/mozilla/defaults/pref /usr/share/config
/usr/share/texmf/dvipdfm/config/ /usr/share/texmf/dvips/config/
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -pipe -mcpu=7400 -maltivec -mabi=altivec -fno-strict-aliasing"
DISTDIR="/usr/portage/distfiles"
FEATURES="buildpkg ccache"
GENTOO_MIRRORS="http://ftp.snt.utwente.nl/pub/os/linux/gentoo
http://212.219.247.17/sites/www.ibiblio.org/gentoo/
http://212.219.247.21/sites/www.ibiblio.org/gentoo/
ftp://ftp.snt.utwente.nl/pub/os/linux/gentoo
http://212.219.247.20/sites/www.ibiblio.org/gentoo/"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="X aalib acl arts autofs berkdb bonobo cdr crypt cups dedicated dga directfb
dnd doc dv dvb dvd dvdr emacs encode esd evo fax fbcon ffmpeg foomaticdb
foreign-package freetds ftp gb gd gdbm gif gnome gnome-libs gnomedb gpg gphoto2
gpm gps gstreamer gtk gtk2 gtkhtml guile imagemagick imap imlib innodb java
javascript jikes jpeg junit kde kerberos krb4 ladcca lcms ldap libwww maildir
mitshm motif mozilla mpeg msn mysql nls offensive oggvorbis opengl oss pam
pcmcia pdflib perl png postgres ppc python qt quicktime readline samba sdl slang
spell ssl tcltk tcpd tetex tiff truetype video_cards_radeon wxwindows xml xml2
xv xvid"
Comment 1 Bryan Stine (RETIRED) gentoo-dev 2004-09-01 18:20:21 UTC
I'm trying to find out if the patch is still needed. If it is, I'll try to bring it up to speed with current drm.
Comment 2 Bryan Stine (RETIRED) gentoo-dev 2004-09-02 23:44:53 UTC
Daenzer said that as far as he knows, this patch is only needed on kernels which do not have the 4-argument vmap. I'm not sure yet about the specifics of vmap and which kernels would apply to that, but I'll do some searching and probably merge a few more kernels to find out.
Comment 3 Kalen Petersen 2004-11-11 15:00:25 UTC
Has there been any new work on this?  The patch still doesn't apply, and attempting to build without it fails rather quickly.  
Comment 4 Bryan Stine (RETIRED) gentoo-dev 2004-11-14 11:00:11 UTC
I did some tinkering with the patch, but that's not accessible to me immediately as my desktop is dead atm. I kinda have doubts that what I did would even work, though.

I can try some stuff again tonight though. Out of curiosity, for which kernel(s) does the build fail? Also, could you post the errors? Thanks.
Comment 5 Frank Russo 2004-12-07 09:31:54 UTC
I am getting the error as well.  Funny thing is that my iMac doesn't even have AGP.  Oh well.  Ping me if you need any other information

imac x11-drm # emerge info
Portage 2.0.51-r8 (default-ppc-2004.1, gcc-3.4.3, glibc-2.3.4.20041102-r0, 2.6.10-rc2-mm4 ppc)
=================================================================
System uname: 2.6.10-rc2-mm4 ppc 740/750
Gentoo Base System version 1.6.7
Python:              dev-lang/python-2.3.4 [2.3.4 (#1, Dec  3 2004, 19:20:28)]
dev-lang/python:     2.3.4
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.8.5-r2, 1.5, 1.4_p6, 1.6.3, 1.7.9, 1.9.3
sys-devel/binutils:  2.15.90.0.3-r3
sys-devel/libtool:   1.5.2-r7
virtual/os-headers:  2.6.8.1-r1
ACCEPT_KEYWORDS="ppc ~ppc"
AUTOCLEAN="yes"
CFLAGS="-O3 -pipe -mcpu=750 -mpowerpc-gfxopt -mmultiple -mstring -funit-at-a-time"
CHOST="powerpc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O3 -pipe -mcpu=750 -mpowerpc-gfxopt -mmultiple -mstring -funit-at-a-time"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache distlocks"
GENTOO_MIRRORS="http://distfiles.gentoo.org http://distro.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://172.16.52.23/gentoo-portage"
USE="X alsa berkdb bitmap-fonts cups dvd encode esd f77 faac faad flac fortran gdbm gif gnome gtk imlib insecure-drivers java jpeg kde nls oggvorbis opengl oss pam perl png ppc python qt readline sdl sndfile ssl tcpd tiff truetype xml xmms video_cards_mach64"
Comment 6 Miguel Sousa Filipe 2004-12-09 17:47:09 UTC
I also have the same problem, using stable "ppc" with x11-drm keyworded "~ppc"

Here's the emerge info:
newton x11-drm # emerge info
Portage 2.0.51-r3 (default-ppc-2004.2, gcc-3.4.1, glibc-2.3.3.20040420-r2, 2.6.9-gentoo-r1 ppc)
=================================================================
System uname: 2.6.9-gentoo-r1 ppc 750FX
Gentoo Base System version 1.4.16
Autoconf: sys-devel/autoconf-2.59-r5
Automake: sys-devel/automake-1.8.5-r1
Binutils: sys-devel/binutils-2.15.90.0.3-r3
Headers:  sys-kernel/linux-headers-2.4.22,sys-kernel/linux-headers-2.4.19-r1
Libtools: sys-devel/libtool-1.5.2-r7
ACCEPT_KEYWORDS="ppc"
AUTOCLEAN="yes"
CFLAGS="-O2 -pipe -mcpu=750 -mpowerpc-gfxopt"
CHOST="powerpc-unknown-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config /usr/kde/3.1/share/config /usr/kde/3/share/config /usr/share/config /var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/terminfo /etc/env.d"
CXXFLAGS="-O2 -pipe -mcpu=750 -mpowerpc-gfxopt"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache distcc distlocks fixpackages sandbox"
GENTOO_MIRRORS="ftp://ftp.rnl.ist.utl.pt/gentoo http://gentoo.oregonstate.edu/ http://www.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY=""
SYNC="rsync://ftp.rnl.ist.utl.pt/gentoo-portage"
USE="X acl alsa arts berkdb cdr chroot crypt divx4linux dvd esd f77 gdbm gif gnome gnome-libs gpm gtk gtk2 imlib ipv6 java jpeg junit motif moznocompose moznoirc mpeg ncurses nls nptl oggvorbis opengl pam perl pic png ppc python quicktime radeon readline samba sdl slang ssl tcltk tcpd theora threads tiff truetype xft xine xinerama xmms xprint xv xvid zlib"

Bye, please fix this.. ;)
Comment 7 Rob Burcham 2005-01-02 10:54:27 UTC
It would seem that the patches included in the ebuild simply do not reliably relate to the x11-drm-20040827 source.  The first patch, 001_ppc_drm-ioremap-agp.patch, starts with two patches against drm/drmP.h... the first applies nicely, but the second looks for 

#if __REALLY_HAVE_AGP

and wants to insert four lines in a indef block related to VMAP_4_ARGS... problem is the __REALLY_HAVE_AGP doesn't exist anywhere in drm/drmP.h so the patch fails.

Why are we trying to apply these patches against a codebase for which they were not made?  Where are the proer patches for the x11-drm-20040827 codebase?  Are there even any to be had?

I am going to try to build this thing by hand.  I thought portage was supposedto prevent these types of mishaps, but this particular package is a mess.
Comment 8 Bryan Stine (RETIRED) gentoo-dev 2005-01-02 18:04:50 UTC
If you try building without the ioremap patch, could you please post the compile errors? An earlier comment indicated that the build fails without the patch, and it would probably make it a bit faster for me to find what needs to be fixed. I don't have any PPC hardware so I need to go jumping into kernel source now to see the 4-arg ioremap stuff.
Comment 9 Fernando Usero 2005-01-03 04:34:17 UTC
Hi Bryan, as you requested here you will the output disabling that patch:

>>> md5 src_uri ;-) x11-drm-20040827-gentoo-0.2.tar.bz2
>>> md5 src_uri ;-) linux-drm-20040827-kernelsource.tar.bz2
QA Notice: USE Flag 'video_cards_ffb' not in IUSE for x11-base/x11-drm-20040827-r1
 * Using koutput kernels is now deprecated. If you use a koutput kernel, please
 * switch to kernel >=2.6.6 with a normal build system.
 * Using KV_OBJ=ko
QA Notice: USE Flag 'video_cards_matrox' not in IUSE for x11-base/x11-drm-20040827-r1
QA Notice: USE Flag 'video_cards_3dfx' not in IUSE for x11-base/x11-drm-20040827-r1
QA Notice: USE Flag 'video_cards_rage128' not in IUSE for x11-base/x11-drm-20040827-r1
QA Notice: USE Flag 'video_cards_radeon' not in IUSE for x11-base/x11-drm-20040827-r1
QA Notice: USE Flag 'video_cards_i810' not in IUSE for x11-base/x11-drm-20040827-r1
QA Notice: USE Flag 'video_cards_i830' not in IUSE for x11-base/x11-drm-20040827-r1
QA Notice: USE Flag 'video_cards_i915' not in IUSE for x11-base/x11-drm-20040827-r1
QA Notice: USE Flag 'video_cards_mach64' not in IUSE for x11-base/x11-drm-20040827-r1
QA Notice: USE Flag 'video_cards_savage' not in IUSE for x11-base/x11-drm-20040827-r1
QA Notice: USE Flag 'video_cards_sis' not in IUSE for x11-base/x11-drm-20040827-r1
QA Notice: USE Flag 'video_cards_via' not in IUSE for x11-base/x11-drm-20040827-r1
QA Notice: USE Flag 'video_cards_ffb' not in IUSE for x11-base/x11-drm-20040827-r1
>>> Checking x11-drm-20040827-gentoo-0.2.tar.bz2's mtime...
>>> Checking linux-drm-20040827-kernelsource.tar.bz2's mtime...
>>> Checking linux-drm-gatos-20031202-kernelsource.tar.bz2's mtime...
>>> WORKDIR is up-to-date, keeping...
 * Building DRM...
mkdir -p /var/tmp/portage/x11-drm-20040827-r1/work/drm/tmp/.tmp_versions
cp //usr/src/linux/.tmp_versions/*.mod /var/tmp/portage/x11-drm-20040827-r1/work/drm/tmp/.tmp_versions
make -C //usr/src/linux  MAKEFILES=/var/tmp/portage/x11-drm-20040827-r1/work/drm/tmp/.config M=/var/tmp/portage/x11-drm-20040827-r1/work/drm SUBDIRS=/var/tmp/portage/x11-drm-20040827-r1/work/drm DRMSRCDIR=/var/tmp/portage/x11-drm-20040827-r1/work/drm \
        MODVERDIR=/var/tmp/portage/x11-drm-20040827-r1/work/drm modules
make[1]: Entering directory `/usr/src/linux-2.6.9-gentoo-r4'
  CC [M]  /var/tmp/portage/x11-drm-20040827-r1/work/drm/radeon_drv.o
In file included from /var/tmp/portage/x11-drm-20040827-r1/work/drm/radeon_drv.c:47:
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_drv.h: In function `drm_probe':
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_drv.h:586: error: initializer element is not constant
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_drv.h:586: error: (near initialization for `drm_driver.remove')
In file included from /var/tmp/portage/x11-drm-20040827-r1/work/drm/radeon_drv.c:55:
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_vm.h:363: error: initializer element is not constant
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_vm.h:363: error: (near initialization for `radeon_vm_ops.nopage')
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_vm.h:370: error: initializer element is not constant
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_vm.h:370: error: (near initialization for `radeon_vm_shm_ops.nopage')
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_vm.h:372: error: initializer element is not constant
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_vm.h:372: error: (near initialization for `radeon_vm_shm_ops.close')
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_vm.h:377: error: initializer element is not constant
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_vm.h:377: error: (near initialization for `radeon_vm_dma_ops.nopage')
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_vm.h:384: error: initializer element is not constant
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_vm.h:384: error: (near initialization for `radeon_vm_sg_ops.nopage')
In file included from /var/tmp/portage/x11-drm-20040827-r1/work/drm/radeon_drv.c:56:
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_stub.h:76: error: initializer element is not constant
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_stub.h:76: error: (near initialization for `radeon_stub_fops.open')
/var/tmp/portage/x11-drm-20040827-r1/work/drm/radeon_drv.c:231: error: syntax error at end of input
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_stub.h:334: warning: unused variable `radeon_stub_info'
/var/tmp/portage/x11-drm-20040827-r1/work/drm/drm_drv.h:65: warning: `drm_cleanup' declared `static' but never defined
make[2]: *** [/var/tmp/portage/x11-drm-20040827-r1/work/drm/radeon_drv.o] Error 1
make[1]: *** [_module_/var/tmp/portage/x11-drm-20040827-r1/work/drm] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.9-gentoo-r4'
make: *** [modules] Error 2
 * Portage could not build the DRM modules. If you see an ACCESS DENIED error,
 * this could mean that you were using an unsupported kernel build system. All
 * 2.4 kernels are supported, but only 2.6 kernels at least as new as 2.6.6
 * are supported.

!!! ERROR: x11-base/x11-drm-20040827-r1 failed.
!!! Function die_error, Line 214, Exitcode 0
!!! Unable to build DRM modules.
!!! If you need support, post the topmost build error, NOT this status message.

By the way, in order to disable the ioremap patch i moved it to "exclude" directory in $PATCHDIR and performed the compile step with ebuild.

good luck!
Comment 10 Bryan Stine (RETIRED) gentoo-dev 2005-01-03 12:48:00 UTC
Thanks very much. This helps me understand a bit of what's going on.

This looks like it might actually be a gcc-3.4 thing. Is that what you're running? My laptop was stuck on gcc-3.3.4, but it's in the process of upgrading now.
Comment 11 Fernando Usero 2005-01-03 13:32:35 UTC
# gcc-config -l
[1] powerpc-unknown-linux-gnu-3.3.3 *
[2] powerpc-unknown-linux-gnu-3.4.3
[3] powerpc-unknown-linux-gnu-3.4.3-hardened
[4] powerpc-unknown-linux-gnu-3.4.3-hardenednopie
[5] powerpc-unknown-linux-gnu-3.4.3-hardenednossp

 # gcc --version
gcc (GCC) 3.3.3 (Gentoo Linux 3.3.3_pre20040408-r1)

Comment 12 Bryan Stine (RETIRED) gentoo-dev 2005-01-03 17:47:15 UTC
Ok, I've found a way to reproduce this on x86. I'm gonna try to see if I can fix it or find a fix.
Comment 13 Bryan Stine (RETIRED) gentoo-dev 2005-01-06 22:22:23 UTC
I've added a 20050104 snapshot to the tree hard-masked. If you're adventurous enough to try it out, echo "=x11-base/x11-drm-20050104" >>/etc/portage/package.unmask and emerge x11-drm. Testing against kernel 2.4.28, the 20040827 snapshot fails to compile (giving the same errors as you get) and the new one succeeds.

I also attempted to bring the ioremap-agp patch up-to-speed with this snapshot. I don't think that the ioremap/vmap stuff has anything to do with the error I get from 2.4.28, though.
Comment 14 Fernando Usero 2005-01-21 15:51:08 UTC
Hi Brian,

now x11-drm compiles and merges without problems.

My problem now is that the i can't get Xorg working with the DRI. But I'm not sure  if this problem is a gentoo-related one. Anyway, i'll talk a bit about it. The relevant part of the log says:

------------------------------------
(WW) RADEON(0): [agp] AGP not available
(EE) RADEON(0): [agp] AGP failed to initialize. Disabling the DRI.
(II) RADEON(0): [agp] You may want to make sure the agpgart kernel module
is loaded before the radeon kernel module.
(II) RADEON(0): [drm] removed 1 reserved context for kernel
(II) RADEON(0): [drm] unmapping 8192 bytes of SAREA 0xe208c000 at 0x320d2000
(II) RADEON(0): Memory manager initialized to (0,0) (1280,6553)
(II) RADEON(0): Reserved area from (0,854) to (1280,856)
(II) RADEON(0): Largest offscreen area available: 1280 x 5697
(II) RADEON(0): Render acceleration enabled
(II) RADEON(0): Using XFree86 Acceleration Architecture (XAA)
        Screen to screen bit blits
        Solid filled rectangles
        8x8 mono pattern filled rectangles
        Indirect CPU to Screen color expansion
        Solid Lines
        Scanline Image Writes
        Offscreen Pixmaps
        Setting up tile and stipple cache:
                32 128x128 slots
                32 256x256 slots
                16 512x512 slots
(II) RADEON(0): Acceleration enabled
(==) RADEON(0): Backing store disabled
(==) RADEON(0): Silken mouse enabled
(II) RADEON(0): Using hardware cursor (scanline 856)
(II) RADEON(0): Largest offscreen area available: 1280 x 5693
(II) RADEON(0): Direct rendering disabled
(==) RandR enabled

-------------------------------------


of course, i've made sure of loading the modules in correct order, but still doesn't work.

Any hints??

Comment 15 Bryan Stine (RETIRED) gentoo-dev 2005-01-22 13:44:43 UTC
(WW) RADEON(0): [agp] AGP not available
(EE) RADEON(0): [agp] AGP failed to initialize. Disabling the DRI.
(II) RADEON(0): [agp] You may want to make sure the agpgart kernel module
is loaded before the radeon kernel module.
---

It appears that you don't have agpgart enabled in the kernel or as a module. If you do, 2.6 kernels also require that you build chipset-specific agp modules to support your hardware. In most cases, AGP GART support is required for direct rendering.
Comment 16 Fernando Usero 2005-01-22 17:50:38 UTC
i added the chipset specific module: uninorth_agp and, now, the Directing Rendering is enabled.

Thanks a lot, Bryan

This bug should be closed....
Comment 17 Bryan Stine (RETIRED) gentoo-dev 2005-01-22 21:14:20 UTC
Glad you got it working.

This will close when the new snapshot is unmasked.
Comment 18 Bryan Stine (RETIRED) gentoo-dev 2005-05-04 12:50:46 UTC
Can anybody check to see if ioremap is still a problem with 20050502?
Comment 19 Donnie Berkholz (RETIRED) gentoo-dev 2005-10-12 19:47:18 UTC
Shouldn't be a problem in 20050807, the patch is no longer applied.