Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 62275 - typo in /etc/conf.d/hdparm
Summary: typo in /etc/conf.d/hdparm
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High trivial (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-30 10:27 UTC by Steve Dibb (RETIRED)
Modified: 2004-09-05 19:18 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Simple patch to fix typo. (62275.patch,467 bytes, patch)
2004-09-04 14:38 UTC, Tom Kirchner
Details | Diff
Fixed patch, no colors (I was tired) (62275.patch,324 bytes, patch)
2004-09-04 14:45 UTC, Tom Kirchner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Dibb (RETIRED) gentoo-dev 2004-08-30 10:27:58 UTC
There's a typo in the configuration file for sys-apps/hdparm in files/hdparm-conf.d and hdparm-conf.d.3

The line that reads "# disc1_args"-d1"" should be: "# disc1_args="-d1"".  It is missing an = sign between disc1_args and "-d1".

Reproducible: Always
Steps to Reproduce:
1. edit /etc/conf.d/hdparm
2. comment default all_args="-d1"
3. uncomment disc1_args"-d1"
4. # /etc/init.d/hdparm restart

Actual Results:  
flynn root # /etc/init.d/hdparm restart
/sbin/runscript.sh: line 9: disc1_args-d1: command not found
 * WARNING:  you are stopping a boot service.
 * Starting hdparm...                                                     [ ok ]

Expected Results:  
flynn root # /etc/init.d/hdparm restart
 * WARNING:  you are stopping a boot service.
 * Starting hdparm...                                                     [ ok ]
 * Running hdparm on /dev/discs/disc1/disc...
Comment 1 Andrew Ross (RETIRED) gentoo-dev 2004-09-03 23:56:11 UTC
Could someone please close this, as the files have already been fixed:

aross@aross-laptop files $ grep all_args hdparm-conf.d*
hdparm-conf.d:# Or, you can set hdparm options for ALL drives using all_args..
hdparm-conf.d:all_args="-d1"
hdparm-conf.d.3:# or, you can set hdparm options for ALL drives using all_args, e.g.
hdparm-conf.d.3:all_args="-d1"
Comment 2 Andrew Ross (RETIRED) gentoo-dev 2004-09-03 23:57:12 UTC
Sorry, my bad (misread the problem). If only we could delete comments... *sheepish grin*
Comment 3 Tom Kirchner 2004-09-04 14:38:41 UTC
Created attachment 38930 [details, diff]
Simple patch to fix typo.
Comment 4 Tom Kirchner 2004-09-04 14:45:51 UTC
Created attachment 38933 [details, diff]
Fixed patch, no colors (I was tired)
Comment 5 Sven Wegener gentoo-dev 2004-09-05 19:18:20 UTC
Commited to CVS. Thanks for reporting!