Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 622700 - >=net-fs/samba-4.5 automagically enables lttng debug support
Summary: >=net-fs/samba-4.5 automagically enables lttng debug support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 622164
  Show dependency tree
 
Reported: 2017-06-25 14:58 UTC by Rick Harris
Modified: 2017-08-23 09:03 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Harris 2017-06-25 14:58:43 UTC 
As above >=samba-4.5 is missing explicitly stating '--without-lttng' or '--with-lttng' at configure time.

To not explicitly state either way results in samba defaulting to enabling lttng debug support if dev-util/lttng-ust is present on the system.

This might not be desirable, eg. in the instance that it breaks Chromium's namespace sandbox
(see https://bugs.chromium.org/p/chromium/issues/detail?id=571277)
Comment 1 Rick Harris 2017-07-07 01:43:16 UTC 
Also breaks 'make install' for media-video/vlc[samba] (see bug# 624068)
Comment 2 Rick Harris 2017-08-17 01:49:26 UTC 
See also bug #622164
Comment 3 Joakim Tjernlund 2017-08-23 08:36:19 UTC 
I just hit this too and it took quite a while to find out why.
Comment 4 Joakim Tjernlund 2017-08-23 08:53:58 UTC 
tried to use EXTRA_ECONF="--without-lttng" but that does not seems
to work for samba, bug or by design?
Comment 5 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-08-23 08:58:56 UTC 
commit 6317e7c12e21da53904f0670ce1ffa9b8eecefd4 (HEAD -> master, origin/master, origin/HEAD)
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Wed Aug 23 10:56:09 2017

    net-fs/samba: Fixed automagic on lttng (bug #622700).

    In samba-4.5.x lttng is now disabled.
    In >=samba-4.6 lttng can now be toggled by the "debug" USE flag.

    Package-Manager: Portage-2.3.8, Repoman-2.3.3
Comment 6 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2017-08-23 08:59:40 UTC 
(In reply to Joakim Tjernlund from comment #4)
> tried to use EXTRA_ECONF="--without-lttng" but that does not seems
> to work for samba, bug or by design?

AFAIK, EXTRA_ECONF only works for autotools-based build system. samba unfortunately uses WAF...
Comment 7 Joakim Tjernlund 2017-08-23 09:03:21 UTC 
(In reply to Lars Wendler (Polynomial-C) from comment #6)
> (In reply to Joakim Tjernlund from comment #4)
> > tried to use EXTRA_ECONF="--without-lttng" but that does not seems
> > to work for samba, bug or by design?
> 
> AFAIK, EXTRA_ECONF only works for autotools-based build system. samba
> unfortunately uses WAF...

But samba accepts the same syntax so I thin WAF should pick up EXTRA_ECONF:

CCFLAGS="-O2 -pipe" LINKFLAGS="-O2 -pipe -Wl,-O1 -Wl,--as-needed" "/var/tmp/portage/net-fs/samba-4.6.7/work/samba-4.6.7/buildtools/bin/waf" --prefix=/usr --libdir=/usr/lib64 --enable-fhs --sysconfdir=/etc --localstatedir=/var --with-modulesdir=/usr/lib64/samba --with-piddir=/run/samba --bundled-libraries=NONE --builtin-libraries=NONE --disable-rpath --disable-rpath-install --nopyc --nopyo --with-acl-support --without-ad-dc --without-dnsupdate --with-ads --without-cluster-support --enable-cups --without-dmapi --with-fam --enable-gnutls --without-gpgme --disable-iprint --with-ldap --with-pam --with-pammodulesdir=/lib64/security --without-quotas --without-syslog --without-systemd --with-system-mitkrb5 --with-winbind --disable-avahi --with-shared-modules=idmap_ad configure