Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 621832 - www-client/firefox-54.0 should depend on dev-util/cargo
Summary: www-client/firefox-54.0 should depend on dev-util/cargo
Status: RESOLVED OBSOLETE
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-15 14:57 UTC by Helmut Jarausch
Modified: 2018-11-17 15:58 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Helmut Jarausch 2017-06-15 14:57:58 UTC
Without dev-util/cargo installed, building firefox-54.0 fails with
ERROR: Cargo package manager not found.
To compile Rust language sources, you must have 'cargo' in your path.
See https://www.rust-lang.org/ for more information.

You can install cargo by running './mach bootstrap'
or by directly running the installer from https://rustup.rs/
Comment 1 James Le Cuirot gentoo-dev 2017-06-15 16:19:50 UTC
firefox DEPENDs on dev-lang/rust and that PDEPENDs on dev-util/cargo. I have had similar issues with PDEPEND in the past. I would like some clarification on how strongly it is enforced, i.e. will Portage ever try to build firefox before cargo?
Comment 2 tt_1 2017-08-08 08:15:07 UTC
It certainly does not work in the intended way, because firefox now depends on virtual/rust to allow it to be build with either dev-lang/rust or dev-lang/rust-bin, but if dev-lang/rust-bin is pulled into the dependency-graph dev-util/cargo will not be pulled in and src_configure of firefox-55.0 ends up failing. 

Oddly the cargo ebuild pulls in rust again, so I doubt the sense of virtual/rust in the firefox ebuild.
Comment 3 Ulenrich 2017-08-09 11:01:59 UTC
Oddly the rust-bin prebuild package also has its own cargo.
Is that a firefox upstream configure error not finding that prebuild cargo?
Comment 4 Enne Eziarc 2017-08-10 00:59:35 UTC
(In reply to Ulenrich from comment #3)
> Oddly the rust-bin prebuild package also has its own cargo.
> Is that a firefox upstream configure error not finding that prebuild cargo?

I don't know if it's the case for older versions, but `qlist rust-bin-1.19.0` shows no trace of a cargo binary.
Comment 5 ernsteiswuerfel archtester 2017-08-15 12:27:54 UTC
Same situation for me, firefox-55.0 build fails due to missing cargo. Rust used: dev-lang/rust-bin-1.15-1
Comment 6 Roman 2017-08-17 16:55:46 UTC
Same here, trying to compile www-client/firefox-55.0.1. What's worse, I have problems compiling dev-lang/rust, see bug #628122.
Comment 7 Roman 2017-08-24 18:38:11 UTC
Actually, to fully fix the compilation, two changes (both one liners) should be done:

1) firefox ebuild should depend on dev-util/cargo

2) dev-util/cargo should depend on virtual/rust instead of dev-lang/rust - so that it can be compiled also using rust-bin (works for me)
Comment 8 Dirkjan Ochtman (RETIRED) gentoo-dev 2017-09-09 13:32:43 UTC
dev-util/cargo now depends on virtual/rust.
Comment 9 ernsteiswuerfel archtester 2018-03-21 19:09:23 UTC
I think this bug can be closed.

FF deps are sorted out since some time and FF 54 is no longer in tree.
Comment 10 Andrzej Korwin-Mikke 2018-11-17 11:57:36 UTC
I just ran into the same issue while installing firefox-63.0.3. Firefox build directly depends on cargo, and should declare it in the ebuild. Not mentioning direct dependencies because other dependencies should depend on them is a bad practice.
Comment 11 Thomas Deutschmann (RETIRED) gentoo-dev 2018-11-17 15:58:04 UTC
Obsolete, we don't have "www-client/firefox-54.0" in repository and >=60 depends on virtual/rust and virtual/cargo.

The problem from Andrzej is bug 671182 and has nothing to do with this one.