Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 621414 - net-misc/modemmanager-1.6.6 bump request
Summary: net-misc/modemmanager-1.6.6 bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2017-06-10 17:02 UTC by Jonas Stein
Modified: 2018-02-07 22:09 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
modemmanager-9999.ebuild file for git usage (modemmanager-9999.ebuild,2.98 KB, text/plain)
2017-06-10 20:36 UTC, Mark Dominik Bürkle
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2017-06-10 17:02:39 UTC
Mark, does a simple bump work for you? 
https://wiki.gentoo.org/wiki/Custom_repository#Simple_version_bump_of_an_ebuild_in_the_local_overlay
Comment 1 Mark Dominik Bürkle 2017-06-10 17:42:23 UTC
version bumping (using "ebuild modemmanager-1.6.6.ebuild manifest" instead of "repoman...") worked, but compiling failed:... lots and lots of deprecation warnings, then:


mm-bearer-qmi.c: At top level:
mm-bearer-qmi.c:856:29: error: unknown type name ‘QmiIndicationWdsEventReportOutput’
                             QmiIndicationWdsEventReportOutput *output,
                             ^
mm-bearer-qmi.c: In function ‘connect_enable_indications_ready’:
mm-bearer-qmi.c:868:5: error: unknown type name ‘QmiMessageWdsSetEventReportOutput’
     QmiMessageWdsSetEventReportOutput *output;
     ^
...
In file included from /usr/include/glib-2.0/gobject/gobject.h:28:0,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from ../libmm-glib/mm-simple-status.h:24,
                 from ../libmm-glib/libmm-glib.h:59,
                 from mm-bearer-qmi.c:28:
mm-bearer-qmi.c:881:42: error: ‘event_report_indication_cb’ undeclared (first use in this function)
                              G_CALLBACK (event_report_indication_cb),
                                          ^
...
mm-bearer-qmi.c: At top level:
mm-bearer-qmi.c:921:8: error: unknown type name ‘QmiMessageWdsSetEventReportInput’
 static QmiMessageWdsSetEventReportInput *
        ^
mm-bearer-qmi.c: In function ‘event_report_input_new’:
mm-bearer-qmi.c:924:5: error: unknown type name ‘QmiMessageWdsSetEventReportInput’
     QmiMessageWdsSetEventReportInput *input;
     ^
...
mm-bearer-qmi.c: In function ‘setup_event_report_unsolicited_events’:
mm-bearer-qmi.c:950:5: error: unknown type name ‘QmiMessageWdsSetEventReportInput’
     QmiMessageWdsSetEventReportInput *input = event_report_input_new (TRUE);
     ^
...
mm-bearer-qmi.c: In function ‘cleanup_event_report_unsolicited_events’:
mm-bearer-qmi.c:966:5: error: unknown type name ‘QmiMessageWdsSetEventReportInput’
     QmiMessageWdsSetEventReportInput *input;
     ^
...
(more and more warnings)

Looks to me like an inherent error, can't be fixed in Gentoo, can it?
Comment 2 Mark Dominik Bürkle 2017-06-10 18:10:20 UTC
got the same (and more) error messages by compiling a

git clone git://anongit.freedesktop.org/ModemManager/ModemManager
cd ModemManager
git checkout 1.6.6
./autogen.sh
make


Aus autogen.sh:
...
config.status: executing po/stamp-it commands

    ModemManager 1.6.6
    ==============================================

    Build:
      compiler:                gcc
      cflags:                  -Wall -Werror -std=gnu89 -g -O2 -Wmissing-declarations -Wmissing-prototypes -Wdeclaration-after-statement -Wno-unused-parameter -Wno-sign-compare -Wno-deprecated-declarations -Wno-unused-but-set-variable -Wformat-security
      ldflags:                 
      maintainer mode:         yes

    System paths:
      prefix:                  /usr/local
      D-Bus system directory:  ${prefix}/etc/dbus-1/system.d
      udev base directory:     /lib/udev
      systemd unit directory:  /usr/lib/systemd/system

    Features:
      policykit support:       strict
      mbim support:            yes
      qmi support:             yes
      suspend/resume support:  systemd

    Miscellaneous:
      gobject introspection:   yes
      vala bindings:           no
      documentation:           no
      code coverage:           no


Aus make:
...
  CC       ModemManager-mm-sim-qmi.o
  CC       ModemManager-mm-bearer-qmi.o
mm-bearer-qmi.c:856:29: Fehler: unbekannter Typname: »QmiIndicationWdsEventReportOutput«
                             QmiIndicationWdsEventReportOutput *output,
                             ^
mm-bearer-qmi.c: In Funktion »connect_enable_indications_ready«:
mm-bearer-qmi.c:868:5: Fehler: unbekannter Typname: »QmiMessageWdsSetEventReportOutput«
     QmiMessageWdsSetEventReportOutput *output;
     ^
mm-bearer-qmi.c:871:14: Fehler: Implizite Deklaration der Funktion »qmi_client_wds_set_event_report_finish« [-Werror=implicit-function-declaration]
     output = qmi_client_wds_set_event_report_finish (client, res, error);
              ^
mm-bearer-qmi.c:871:12: Fehler: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung [-Werror=int-conversion]
     output = qmi_client_wds_set_event_report_finish (client, res, error);
            ^
mm-bearer-qmi.c:872:21: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_output_get_result« [-Werror=implicit-function-declaration]
     if (!output || !qmi_message_wds_set_event_report_output_get_result (output, error)) {
                     ^
mm-bearer-qmi.c:874:13: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_output_unref« [-Werror=implicit-function-declaration]
             qmi_message_wds_set_event_report_output_unref (output);
             ^
In file included from /usr/include/glib-2.0/gobject/gobject.h:28:0,
                 from /usr/include/glib-2.0/gobject/gbinding.h:29,
                 from /usr/include/glib-2.0/glib-object.h:23,
                 from ../libmm-glib/mm-simple-status.h:24,
                 from ../libmm-glib/libmm-glib.h:59,
                 from mm-bearer-qmi.c:28:
mm-bearer-qmi.c:881:42: Fehler: »event_report_indication_cb« nicht deklariert (erste Benutzung in dieser Funktion)
                              G_CALLBACK (event_report_indication_cb),
                                          ^
/usr/include/glib-2.0/gobject/gsignal.h:475:60: Anmerkung: in Definition des Makros »g_signal_connect«
     g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
                                                            ^
mm-bearer-qmi.c:881:30: Anmerkung: bei Substitution des Makros »G_CALLBACK«
                              G_CALLBACK (event_report_indication_cb),
                              ^
mm-bearer-qmi.c:881:42: Anmerkung: jeder nicht deklarierte Bezeichner wird nur einmal für jede Funktion, in der er vorkommt, gemeldet
                              G_CALLBACK (event_report_indication_cb),
                                          ^
/usr/include/glib-2.0/gobject/gsignal.h:475:60: Anmerkung: in Definition des Makros »g_signal_connect«
     g_signal_connect_data ((instance), (detailed_signal), (c_handler), (data), NULL, (GConnectFlags) 0)
                                                            ^
mm-bearer-qmi.c:881:30: Anmerkung: bei Substitution des Makros »G_CALLBACK«
                              G_CALLBACK (event_report_indication_cb),
                              ^
mm-bearer-qmi.c: Auf höchster Ebene:
mm-bearer-qmi.c:921:8: Fehler: unbekannter Typname: »QmiMessageWdsSetEventReportInput«
 static QmiMessageWdsSetEventReportInput *
        ^
mm-bearer-qmi.c: In Funktion »event_report_input_new«:
mm-bearer-qmi.c:924:5: Fehler: unbekannter Typname: »QmiMessageWdsSetEventReportInput«
     QmiMessageWdsSetEventReportInput *input;
     ^
mm-bearer-qmi.c:926:13: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_new« [-Werror=implicit-function-declaration]
     input = qmi_message_wds_set_event_report_input_new ();
             ^
mm-bearer-qmi.c:926:11: Fehler: Zuweisung erzeugt Zeiger von Ganzzahl ohne Typkonvertierung [-Werror=int-conversion]
     input = qmi_message_wds_set_event_report_input_new ();
           ^
mm-bearer-qmi.c:927:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_extended_data_bearer_technology« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_extended_data_bearer_technology (input, enable, NULL);
     ^
mm-bearer-qmi.c:928:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_limited_data_system_status« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_limited_data_system_status (input, enable, NULL);
     ^
mm-bearer-qmi.c:929:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_uplink_flow_control« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_uplink_flow_control (input, enable, NULL);
     ^
mm-bearer-qmi.c:930:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_data_systems« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_data_systems (input, enable, NULL);
     ^
mm-bearer-qmi.c:931:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_evdo_pm_change« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_evdo_pm_change (input, enable, NULL);
     ^
mm-bearer-qmi.c:932:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_preferred_data_system« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_preferred_data_system (input, enable, NULL);
     ^
mm-bearer-qmi.c:933:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_data_call_status« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_data_call_status (input, enable, NULL);
     ^
mm-bearer-qmi.c:934:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_current_data_bearer_technology« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_current_data_bearer_technology (input, enable, NULL);
     ^
mm-bearer-qmi.c:935:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_mip_status« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_mip_status (input, enable, NULL);
     ^
mm-bearer-qmi.c:936:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_dormancy_status« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_dormancy_status (input, enable, NULL);
     ^
mm-bearer-qmi.c:937:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_data_bearer_technology« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_data_bearer_technology (input, enable, NULL);
     ^
mm-bearer-qmi.c:938:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_set_channel_rate« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_set_channel_rate (input, enable, NULL);
     ^
mm-bearer-qmi.c: In Funktion »setup_event_report_unsolicited_events«:
mm-bearer-qmi.c:950:5: Fehler: unbekannter Typname: »QmiMessageWdsSetEventReportInput«
     QmiMessageWdsSetEventReportInput *input = event_report_input_new (TRUE);
     ^
mm-bearer-qmi.c:952:5: Fehler: Implizite Deklaration der Funktion »qmi_client_wds_set_event_report« [-Werror=implicit-function-declaration]
     qmi_client_wds_set_event_report (client,
     ^
mm-bearer-qmi.c:958:5: Fehler: Implizite Deklaration der Funktion »qmi_message_wds_set_event_report_input_unref« [-Werror=implicit-function-declaration]
     qmi_message_wds_set_event_report_input_unref (input);
     ^
mm-bearer-qmi.c: In Funktion »cleanup_event_report_unsolicited_events«:
mm-bearer-qmi.c:966:5: Fehler: unbekannter Typname: »QmiMessageWdsSetEventReportInput«
     QmiMessageWdsSetEventReportInput *input;
     ^
mm-bearer-qmi.c: In Funktion »connect_enable_indications_ready«:
mm-bearer-qmi.c:883:1: Fehler: Kontrollfluss erreicht Ende von Nicht-void-Funktion [-Werror=return-type]
 }
 ^
cc1: Alle Warnungen werden als Fehler behandelt
make[4]: *** [Makefile:1499: ModemManager-mm-bearer-qmi.o] Fehler 1
make[4]: Verzeichnis „/usr/src/ModemManager/src“ wird verlassen
make[3]: *** [Makefile:1630: all-recursive] Fehler 1
make[3]: Verzeichnis „/usr/src/ModemManager/src“ wird verlassen
make[2]: *** [Makefile:754: all] Fehler 2
make[2]: Verzeichnis „/usr/src/ModemManager/src“ wird verlassen
make[1]: *** [Makefile:536: all-recursive] Fehler 1
make[1]: Verzeichnis „/usr/src/ModemManager“ wird verlassen
make: *** [Makefile:468: all] Fehler 2
mdb@lapmdb-hpl /usr/src/ModemManager $>>
Comment 3 Mark Dominik Bürkle 2017-06-10 18:23:02 UTC
ModemManager-git-head needs

libqmi ~amd64 (1.18.0, >=1.17.900)

and compiles. Is now running the tests...plugins...done.

=> is it possible to create a git-head-snapshot variant of modemmanager.ebuild?

Hesitating to run "make install" and give it a try...
Comment 4 Mark Dominik Bürkle 2017-06-10 20:36:44 UTC
Created attachment 475962 [details]
modemmanager-9999.ebuild file for git usage

created a -9999.ebuild file for git usage.
ModemManager seems to work as before - didn't test a lot though.
Comment 5 Mark Dominik Bürkle 2017-06-10 20:39:50 UTC
would anyone be so kind to check if the ebuild needs some corrections and add it to the tree?

Thanks,
mdb
Comment 6 Mart Raudsepp gentoo-dev 2017-06-11 20:26:03 UTC
I'm not very excited about any -9999 ebuilds here, as we (gnome team) don't really do those yet, and they'd get outdated rather sooner than later.
Would a 1.6.6 that doesn't fail compilation be sufficient here for the MedionMobile Stick issues fixing purposes?
Comment 7 Mark Dominik Bürkle 2017-06-11 23:06:03 UTC
Hi,

the git-head version of ModemManager compiles but has the same issues (with my MedionMobile stick), so a 1.6.6 ebuild would not help at all.

I'll keep the -9999 ebuild in my local overlay to further investigate when I have time again.

Can be closed as wontfix.

Kind regards,
mdb
Comment 8 Mart Raudsepp gentoo-dev 2017-06-12 08:16:04 UTC
It's pending for the bump, so it's fine to keep open for those purposes.
The new version could benefit other users, or improve compatibility with newer networkmanager, or whatever its NEWS/ChangeLog says.
We don't have ModemManager track by our outdated versions check scripts, so a bug to track it is not a problem, as it's not useless like they would be for stuff reported by our used script, whose generated report can be seen at e.g http://dev.gentoo.org/~leio/gnome/
Comment 9 Gilles Dartiguelongue (RETIRED) gentoo-dev 2018-01-19 08:13:49 UTC
Just pushed modemmanager 1.6.12 to the tree.