Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 6214 - portagemaster-1.8.ebuild (Update)
Summary: portagemaster-1.8.ebuild (Update)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Karl Trygve Kalleberg (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-08-08 13:10 UTC by Jelmer Jaarsma
Modified: 2003-02-04 19:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
portagemaster-0.1.8.ebuild (portagemaster-0.1.8.ebuild,740 bytes, text/plain)
2002-08-08 13:13 UTC, Jelmer Jaarsma
Details
wrapper file to start portagemaster (portagemaster,48 bytes, text/plain)
2002-08-17 07:35 UTC, Jelmer Jaarsma
Details
wrapper script version 2 (portagemaster,67 bytes, text/plain)
2002-08-17 07:43 UTC, Jelmer Jaarsma
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jelmer Jaarsma 2002-08-08 13:10:29 UTC
I updated the portagemaster ebuild to version 0.1.8
It needed a couple of extra dependencies since the jar file is now compiled on
your system.
Also, on my system I needed ant-1.5, as 1.4.1 was br0ken. I got the ebuilds for
ant-1.5 from bugzilla bug 5614
Comment 1 Jelmer Jaarsma 2002-08-08 13:13:48 UTC
Created attachment 2922 [details]
portagemaster-0.1.8.ebuild
Comment 2 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2002-08-16 09:27:06 UTC
It works with ant-1.4.1-r1 over here. I've run into a few problems with your
ebuild, however:

1) The header is missing the $Header:$ sentence.
2) You should depend on a specific version of Jikes (>=1.15) and ant (>=1.4.1),
unless you have tested _ALL_ older versions.
3) src_unpack is superfluous
4) Your package not only needs the JDK 1.4 to be installed, it must also be the
system default JDK. A check should be put into pkg_setup().
5) You install a .jar file into /usr/bin. Install it with dojar, and write
a small bash script (named portagemaster) that you put into /usr/sbin (from what
I can see, there is no reason why regular users should want to run portagemaster).
6) You should do dodoc on INSTALL.


I've fixed all these points except 5). If you attach a portagemaster bash
script, I'll stuff all of this into the Portage Tree with no further delay.
Comment 3 Jelmer Jaarsma 2002-08-17 07:35:51 UTC
Created attachment 3160 [details]
wrapper file to start portagemaster

Thanks for the comments. This was my first attempt at making an ebuild, and I
kind of expected to have done a couple of things wrong :)
Comment 4 Jelmer Jaarsma 2002-08-17 07:43:25 UTC
Created attachment 3161 [details]
wrapper script version 2

oops, made a stupid mistake. This should fix it.
Comment 5 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2002-09-08 15:39:11 UTC
I've rewritten Robin Cull's submission (random pick; there were three submitted
scripts + ebuilds). It is now available as app-admin/portagemaster-0.1.8