Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 621070 - app-dicts/gjitenkai new ebuild replacement for deprecated app-dicts/gjiten
Summary: app-dicts/gjitenkai new ebuild replacement for deprecated app-dicts/gjiten
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords: EBUILD
Depends on:
Blocks:
 
Reported: 2017-06-06 20:14 UTC by Niranjan
Modified: 2017-07-05 13:33 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
app-dicts/gjitenkai-0.1.1 (gjitenkai-0.1.1.ebuild,769 bytes, text/plain)
2017-06-06 20:14 UTC, Niranjan
Details
app-dicts/gjitenkai-0.1.1 updated ebuild with repoman errors corrected (gjitenkai-0.1.1.ebuild,742 bytes, text/plain)
2017-06-06 22:36 UTC, Niranjan
Details
Metadata for Gjiten Kai (metadata.xml,528 bytes, text/xml)
2017-06-06 22:37 UTC, Niranjan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Niranjan 2017-06-06 20:14:34 UTC
Created attachment 475418 [details]
app-dicts/gjitenkai-0.1.1

app-dicts/gjiten is slated for removal in bug 608404.  The suggested replacement, app-dicts/gwaei, appears to be effectively unmaintained while undergoing an extensive re-write and has received no updates in roughly four years despite the existence of non-trivial bugs.  Gjiten has a currently maintained fork called Gjiten Kai/グジテン改 that offers rough feature parity with the older Gjiten 2.6 series.  I have written a bare bones ebuild for the most recent release of Gjiten Kai and attached it to this bug.
Comment 1 Jonas Stein gentoo-dev 2017-06-06 20:20:33 UTC
Thank you.

please test the ebuild with repoman and fix the problems 

we should bump to EAPI="6" too.

KEYWORDS="~amd64"
Was there no ~x86 by intention?


DEPEND="
   x11-libs/gtk+:3
"

Better: 
DEPEND="x11-libs/gtk+:3"
Comment 2 Niranjan 2017-06-06 22:36:33 UTC
Created attachment 475428 [details]
app-dicts/gjitenkai-0.1.1 updated ebuild with repoman errors corrected

I updated the syntax for the ebuild after running repoman.  EAPI has been updated to "6" as suggested.  ~x86 was left off of keywords only because I am running an amd64 system and didn't test the built on x86.  I've re-added it.

I have one more minor error from repoman about my calling "addpredict" in the ebuild.  I am not sure how to rectify this.  I added this into the ebuild as a workaround for a sandbox access violation error that I encountered when trying to install glib schemas for the the package.  I got the workaround from this thread <ttps://forums.gentoo.org/viewtopic-t-1033790-start-0.html> as the same error was discussed and solved there.
Comment 3 Niranjan 2017-06-06 22:37:01 UTC
Created attachment 475430 [details]
Metadata for Gjiten Kai
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-07-05 13:33:04 UTC
Comment on attachment 475428 [details]
app-dicts/gjitenkai-0.1.1 updated ebuild with repoman errors corrected

># Copyright 1999-2014 Gentoo Foundation

You need to replace your calendar ;-).

># Distributed under the terms of the GNU General Public License v2
>
>EAPI="6"
>
>inherit cmake-utils gnome2-utils
>
>DESCRIPTION="A new implementation of Gjiten, a Gnome japanese dictionary"
>HOMEPAGE="https://github.com/odrevet/gjitenkai"
>SRC_URI="https://github.com/odrevet/gjitenkai/archive/${PV}.tar.gz"

Please add '-> ${P}.tar.gz' to rename it from 'v0.1.1.tar.gz' -- this is not a good name for a tarball.

>
>LICENSE="GPL-3"
>SLOT="0"
>KEYWORDS="~amd64 ~x86"
>
>DEPEND="x11-libs/gtk+:3"
>
>RDEPEND="${DEPEND}"
>
>pkg_preinst() {
>	gnome2_icon_savelist

This one is no longer necessary.

>	gnome2_schemas_savelist
>}
>
>src_install() {
>	addpredict "/usr/share/glib-2.0/schemas/"

You should look into patching CMakeLists.txt to not call the updater automatically. Since upstream seems to do that on purpose, you'd probably have to add an option() that defaults to ON and set it to OFF in Gentoo ebuild, and wrap the 'compile_schemas_install' call in it. Alternatively, file a bug upstream asking politely to make disabling it possible, and just remove that call from CMakeLists.txt in Gentoo (via patch or sed) ;-).

>	cd "${WORKDIR}"/"${P}"_build/
>	default

This is wrong but after fixing the unnecessary addpredict, it will be gone anyway.

>}
>
>pkg_postinst() {
>	gnome2_icon_cache_update
>	gnome2_schemas_update
>}
>
>pkg_postrm() {
>	gnome2_icon_cache_update
>	gnome2_schemas_update
>}