Bug 620954 – =media-sound/ardour-4.7-r1 fixes to compile after upgrade to gcc-5

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Mark Dominik Bürkle 2017-06-05 21:15:43 UTC]

Created attachment 475300 [details, diff]
/etc/portage/patches/media-sound/ardour/ patches, 1 of 5

After updating to gcc-5, ardour-4.7 no longer compiles.

There were some "== 0" and "!= 0" comparisons of pointers which gcc-5 does not seem to understand any more. (?? WTF ??)
I created a bunch of user-patches and modified the ebuild file (include epatch_user) as a workaround.

The patches make implicit type casts where "== 0" was tested and remove "!= 0" in the other cases.


to patch ardour-4.7-r1.ebuild:
--- media-sound/ardour/ardour-4.7-r1.ebuild.old	2017-06-05 07:06:10.417275997 +0200
+++ media-sound/ardour/ardour-4.7-r1.ebuild	2017-06-05 04:26:44.930812407 +0200
@@ -107,6 +107,7 @@
 	append-flags "-lboost_system"
 	python_fix_shebang "${S}"/wscript
 	python_fix_shebang "${S}"/waf
+	epatch_user
 }
 
 src_configure() {

[Comment 1 Mark Dominik Bürkle 2017-06-05 21:16:07 UTC]

Created attachment 475302 [details, diff]
/etc/portage/patches/media-sound/ardour/ patches, 2 of 5

[Comment 2 Mark Dominik Bürkle 2017-06-05 21:16:28 UTC]

Created attachment 475304 [details, diff]
/etc/portage/patches/media-sound/ardour/ patches, 3 of 5

[Comment 3 Mark Dominik Bürkle 2017-06-05 21:16:49 UTC]

Created attachment 475306 [details, diff]
/etc/portage/patches/media-sound/ardour/ patches, 4 of 5

[Comment 4 Mark Dominik Bürkle 2017-06-05 21:17:17 UTC]

Created attachment 475308 [details, diff]
/etc/portage/patches/media-sound/ardour/ patches, 5 of 5

[Comment 5 Jonas Stein 2017-06-06 15:21:25 UTC]

Thank you.

[Comment 6 Andreas Schürch 2017-06-08 16:44:34 UTC]

Thank you very much Mark! This is highly appreciated! :-)
I combined the patches into one file and committed it in an -r2 version.