Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 620908 - net-p2p/rtorrent: doesnt build against dev-util/cppunit-1.14.0
Summary: net-p2p/rtorrent: doesnt build against dev-util/cppunit-1.14.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jason Zaman
URL:
Whiteboard:
Keywords:
: 623630 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-06-05 13:19 UTC by Nado
Modified: 2017-08-19 10:15 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
autoconf.out (autoconf.out,295 bytes, text/plain)
2017-06-05 13:24 UTC, Nado
Details
rtorrent-0.9.6-cppunit-pkgconfig.patch (rtorrent-0.9.6-cppunit-pkgconfig.patch,824 bytes, patch)
2017-08-17 14:29 UTC, Ben Kohler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nado 2017-06-05 13:19:52 UTC
This version of cppunit doesnt install the file /usr/share/aclocal/cppunit.m4, required by autoconf build systems such as the one used in rtorrent.

Reproducible: Always

Steps to Reproduce:
1. Make sure cppunit-1.14.0 is installed
2. Emerge rtorrent
Actual Results:  
rtorrent fails to build

Expected Results:  
rtorrent should not fail to build because of other packages files.
Comment 1 Nado 2017-06-05 13:24:25 UTC
Created attachment 475238 [details]
autoconf.out

Autoconf error for rtorrent
Comment 2 Nado 2017-06-05 13:25:55 UTC
Line indicating that the aclocal file wasnt installed when updating to dev-util/cppunit-1.14.0 from dev-util/cppunit-1.13.2-r2

--- !empty   dir /usr/share/aclocal
Comment 3 Nado 2017-06-05 14:13:48 UTC
According to these commits :
https://cgit.freedesktop.org/libreoffice/cppunit/commit/?id=c81afa737307ef525258cfae24eb3f2845ce7208
https://cgit.freedesktop.org/libreoffice/cppunit/commit/?id=fcc84eec40acf8506f2a5fcc3fe0399663d1ce18

It seems like they moved everything to a pkg-config way of doing it, thus, it is rtorrent (and maybe more) which havent been updated accordingly.
Comment 4 Ben Kohler gentoo-dev 2017-08-17 13:42:08 UTC
Upstream rtorrent has probably fixed this here: https://github.com/rakshasa/rtorrent/commit/71a52bfac2e43bce46827c769a7135744982c2f3
Comment 5 Ben Kohler gentoo-dev 2017-08-17 13:42:34 UTC
*** Bug 623630 has been marked as a duplicate of this bug. ***
Comment 6 Ben Kohler gentoo-dev 2017-08-17 13:49:35 UTC
There's been a lot of upstream activity since the last release, maybe time to bump to a snapshot?
Comment 7 Ben Kohler gentoo-dev 2017-08-17 14:29:15 UTC
Created attachment 489384 [details, diff]
rtorrent-0.9.6-cppunit-pkgconfig.patch

This is upstream's patch re-rolled to apply after our ncurses & tinfo patches, this seems to fix the issue for me.  I think this would be the way to go if you're against a new snapshot ebuild.

Though if we bump to a snapshot ebuild, our ncurses & tinfo patches probably need to be re-rolled as well..
Comment 8 Jason Zaman gentoo-dev 2017-08-19 10:15:14 UTC
commit cd9ec0ed5640e05a515e3f68cad24e9dad23c3c7
Author: Jason Zaman <perfinion@g.o>
Date:   Sat Aug 19 14:59:36 2017

    net-p2p/rtorrent: fix building against cppunit (bug 620908)
    
    Thanks to Nado and Ben Kohler
    
    Package-Manager: Portage-2.3.6, Repoman-2.3.1

I added a -r1 with this patch in first. I'll also add a snapshot ebuild