619484 – dev-vcs/git uses again "libsecret" instead of "gnome-keyring" USE flag for the same function

Bug 619484 - dev-vcs/git uses again "libsecret" instead of "gnome-keyring" USE flag for the same function

Summary: dev-vcs/git uses again "libsecret" instead of "gnome-keyring" USE flag for th...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Robin Johnson

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2017-05-23 22:47 UTC by Pacho Ramos
Modified:	2017-05-24 08:49 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Pacho Ramos gentoo-dev

2017-05-23 22:47:20 UTC

We are trying for a long time to get rid of libsecret USE flag in favor of "gnome-keyring" as explained here:
https://wiki.gentoo.org/wiki/Project:GNOME/Gnome_Team_Ebuild_Policies#gnome-keyring_and_libsecret

But it seems git ebuild had been changed in the reverse way (probably due to a mistake)

Thanks

Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2017-05-23 23:06:41 UTC

I'll take care of it tomorrow.

Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2017-05-24 07:57:08 UTC

I'm a bit confused. I changed git ebuilds to use libsecret because of bug #610376. Now I wonder what is this bug about. Is just the name of the USE flag incorrect or should git (again) use gnome-base/libgnome-keyring instead of app-crypt/libsecret?

Comment 3 Pacho Ramos gentoo-dev

2017-05-24 08:22:13 UTC

Is about the name of the USE flag, as the ebuild attached there, this should use "gnome-keyring" name for the USE flag even relying on app-crypt/libsecret https://bugs.gentoo.org/show_bug.cgi?id=610376#c7

Comment 4 Mart Raudsepp gentoo-dev

2017-05-24 08:33:16 UTC

Once this is fixed, bug 610920 will turn out to have been unnecessary as well.

Comment 5 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2017-05-24 08:49:26 UTC

commit 7ef9302c5539aa6ea229ed1aacca2f07cfeeecdb (HEAD -> master, origin/master, origin/HEAD)
Author: Lars Wendler <polynomial-c@gentoo.org>
Date:   Wed May 24 10:48:43 2017

    dev-vcs/git: Replace "libsecret" by "gnome-keyring" USE flag (bug #619484)
    
    Package-Manager: Portage-2.3.6, Repoman-2.3.2