619184 – app-portage/repoman - obsolete QA check for compatibility with <=portage-2.1.6.7

Bug 619184 - app-portage/repoman - obsolete QA check for compatibility with <=portage-2.1.6.7

Summary: app-portage/repoman - obsolete QA check for compatibility with <=portage-2.1.6.7

Status:	RESOLVED WONTFIX

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Repoman (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2017-05-21 12:43 UTC by Coacher
Modified:	2022-07-12 03:18 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Coacher 2017-05-21 12:43:25 UTC

Hello.

See bin/ebuild.sh:

if [[ -n $ECLASS && -n ${!__export_funcs_var} ]] ; then
    echo "QA Notice: EXPORT_FUNCTIONS is called before inherit in" \
        "$ECLASS.eclass. For compatibility with <=portage-2.1.6.7," \
        "only call EXPORT_FUNCTIONS after inherit(s)." \
        | fmt -w 75 | while read -r ; do eqawarn "$REPLY" ; done
fi

The mentioned portage version was removed 5 years ago: https://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/sys-apps/portage/portage-2.1.6.7.ebuild?hideattic=0&view=log

We should move on and drop this check.

Comment 1 Michał Górny archtester

2017-05-21 13:14:51 UTC

We may drop the 'for compatibility' part but I think it's better to have EXPORT_FUNCTIONS after inherit anyway.

Comment 2 Sam James archtester

2022-07-12 03:18:16 UTC

repoman support has been removed per bug 835013.

Please file a new bug (or, I suppose, reopen this one) if you feel this check is still applicable to pkgcheck and doesn't already exist.