616696 – sci-libs/bliss is linked to gmp even when USE=-gmp is set

Bug 616696 - sci-libs/bliss is linked to gmp even when USE=-gmp is set

Summary: sci-libs/bliss is linked to gmp even when USE=-gmp is set

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Christoph Junghans (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2017-04-27 01:29 UTC by François Bissey
Modified:	2017-08-01 07:35 UTC (History)
CC List:	2 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description François Bissey 2017-04-27 01:29:09 UTC

bliss has a gmp useflag but at the moment it is ineffective. libbliss will be linked to gmp regardless of the value of the useflag.

This is because there is a small mistake in the autotools patch
+AC_ARG_WITH([gmp],
+  [AS_HELP_STRING([--with-gmp], [enable support for GNU Multiple Precision Arithmetic Library @<:@default=check@:>@])],
+  [], [with_readline=no])
+AS_IF([test "x$with_readline" != xno],
+  [AC_CHECK_HEADERS([gmp.h],,AC_MSG_ERROR([Cannot find gmp.h header]))
+    AC_CHECK_LIB([gmp],_init,,AC_MSG_ERROR([Cannot find gmp library]))
+    AC_SUBST([GMP],[-lgmp])
+    [CPPFLAGS="$CPPFLAGS -DBLISS_USE_GMP"]])

Not that the default for AC_ARG_WITH is not with_gmp as it should be but with_readline. That would be ok if it was the only mistake but the substitution is repeated on the next line in the AS_IF statement. This will only work as expected if no --with-gmp or --without-gmp statement is passed to configure.

Comment 1 François Bissey 2017-08-01 07:35:39 UTC

Fixed by https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=31ded7e602d4797cdd012e18bfeca3751ee5b875

Thank you Sébastian Fabbro.