Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 61669 - Orinoco Monitor mode patch in gentoo-dev-sources?
Summary: Orinoco Monitor mode patch in gentoo-dev-sources?
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL: http://airsnort.shmoo.com/orinocoinfo...
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2004-08-25 11:37 UTC by Jurek Bartuszek (RETIRED)
Modified: 2004-11-08 18:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Newest patch. Works with 2.6.7 and 2.6.8 gentoo-dev-sources releases perfectly (orinoco-0.13e-dragorn-patch.diff,24.87 KB, patch)
2004-08-25 11:39 UTC, Jurek Bartuszek (RETIRED)
Details | Diff
2.6.9-orinoco-monitor.patch (2.6.9-orinoco-monitor.patch,21.60 KB, patch)
2004-11-07 16:05 UTC, Jeremy Huddleston (RETIRED)
Details | Diff
2.6.9-orinoco-monitor.patch (2.6.9-orinoco-monitor.patch,22.41 KB, patch)
2004-11-08 01:38 UTC, Jeremy Huddleston (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jurek Bartuszek (RETIRED) gentoo-dev 2004-08-25 11:37:08 UTC
How about adding the orinoco monitor mode patch into the gentoo-dev-sources patchset?

Reproducible: Always
Steps to Reproduce:
Comment 1 Jurek Bartuszek (RETIRED) gentoo-dev 2004-08-25 11:39:06 UTC
Created attachment 38189 [details, diff]
Newest patch. Works with 2.6.7 and 2.6.8 gentoo-dev-sources releases perfectly

This one works for me fine :)
Comment 2 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-08-25 14:20:36 UTC
Is is already in the 2.6.9-rc kernel?
Comment 3 Jurek Bartuszek (RETIRED) gentoo-dev 2004-08-25 15:25:41 UTC
Thanks for reply!

I've browsed the ChangeLog-2.6.9-r1 file for some orinoco monitor mode entry. Unfortunately - I didn't find anything about it. Although there are many orinoco fixes and enhancements I think there is no monitoring mode implemented whatsoever :(

I think adding this patch to the gentoo-dev-sources patchset is a good thing to do :) Further releases of 2.6.8-rX could already contain it.
Comment 4 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-08-25 23:06:19 UTC
Sorry, but we don't add patches that add features that aren't supported by
the upstream kernel.  I suggest you get this patch into the main kernel.org tree
and then everyone (not only gentoo) can benifit.

Please send the patch to the orinoco driver maintainer.
Comment 5 Jurek Bartuszek (RETIRED) gentoo-dev 2004-08-26 13:53:18 UTC
Ok. I think that this patch should be added into the main kernel.org tree. However, there were also features (i.e. supermount) in gentoo-dev-sources-2.6.7 tree, which previously never (am I wrong now?) showed up in vanilla kernels. I don't really understand the reason of rejecting this patch :(

Regards
Comment 6 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-08-26 15:23:44 UTC
Supermount is now gone :)

We only have a few "feature" patches that are hanging around due to people depending on them:
  - squashfs (the livecds need it)
  - speakup (needed for better accessibility to users)
  - bootsplash

All of these patches are being activly worked on to get into the mainline kernel.

I agree, we need to document the policy here, haven't had the time to do it yet, sorry.
Comment 7 Jurek Bartuszek (RETIRED) gentoo-dev 2004-08-26 16:31:43 UTC
Yes, that one would be definitely useful ;-)
Comment 8 Jeremy Huddleston (RETIRED) gentoo-dev 2004-11-07 15:52:16 UTC
greg/dsd: can we get an exception here?  the patch actually comes from the orinoco maintainer, but it hasn't been integrated into the mainline kernel tree yet.

See:
http://ozlabs.org/people/dgibson/dldwd/
http://ozlabs.org/people/dgibson/dldwd/monitor-0.13e.patch

This patch is actually applied against the pcmcia-cs package in portage which unfortunately only benefits 2.4 users.  I've updated the patch to apply against 2.6.9, and I'll attach it here after testing.  If you don't want it in g-d-s, then atleast people will be able to grab it here...
Comment 9 Jeremy Huddleston (RETIRED) gentoo-dev 2004-11-07 16:05:36 UTC
Created attachment 43499 [details, diff]
2.6.9-orinoco-monitor.patch
Comment 10 Jeremy Huddleston (RETIRED) gentoo-dev 2004-11-08 01:38:33 UTC
Created attachment 43518 [details, diff]
2.6.9-orinoco-monitor.patch

here we go...
Comment 11 Greg Kroah-Hartman (RETIRED) gentoo-dev 2004-11-08 18:55:38 UTC
If we offer an exception for this, where do we stop?  :)

And yes, this is the driver for my laptop, so I agree, it would be nice to have.

But it also will conflict when 2.6.10 comes out, right?  Due to the changes to 
this driver that have already happened.  Let's let David (the driver author) get
the changes into the main kernel tree, as he's already started to do.

Oh, and if this patch is in the tree, _no one_ would be willing to support it
(not david, the driver author, not the kernel.org people, and certianly not me...)