Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 616414 - media-radio/gpredict needs jpeg dependency for x11-libs/gdk-pixbuf
Summary: media-radio/gpredict needs jpeg dependency for x11-libs/gdk-pixbuf
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Thomas Beierlein
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-23 20:13 UTC by Jess Haas
Modified: 2017-05-01 13:27 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jess Haas 2017-04-23 20:13:14 UTC
media-radio/gpredict uses the x11-libs/goocanvas ebuild to load jpeg images which in turn uses x11-libs/gdk-pixbuf to load them. This requires gdk-pixbuf to be built with the jpeg use flag. I propose that the gpredict ebuild require a yet to be created jpeg use flag from x11-libs/goocanvas which will in turn require x11-libs/gdk-pixbuf to be built with the jpeg use flag.

Fixing this bug in the gpredict ebuild requires fixing bug Bug# 61640( https://bugs.gentoo.org/show_bug.cgi?id=616410 ) for the goocanvas ebuild. 

-Jess
Comment 1 Thomas Beierlein gentoo-dev 2017-04-29 16:30:58 UTC
Thanks for reporting Jess. Nice catch.

I think it is much easier to simply not rely on goocanvas or gtk bringing in gdk_pixbuf but add x11-libs/gdk_pixbuf[jpeg] to gpredicts rdeps.
Comment 2 Jess Haas 2017-04-29 16:55:48 UTC
That works, i just thought it was a bit weird since gpredict doesnt use gdk_pixbuff directly, goocanvas does. Seems that if there was a jpeg use flag for goocanvas when people create ebuilds for other things that use it they would be more likely to include it as a dependency than to include gdk-pixbuf[jpeg] which isnt even listed as a dependency of their app.
Comment 3 Thomas Beierlein gentoo-dev 2017-04-29 17:34:18 UTC
Fixed in gpredict-1.3-r1.
> media-radio/gpredict: Add missing USE dep (Bug #616414). Thanks J.Haas
Comment 4 Thomas Beierlein gentoo-dev 2017-05-01 13:27:17 UTC
(In reply to Jess Haas from comment #2)
> That works, i just thought it was a bit weird since gpredict doesnt use
> gdk_pixbuff directly, goocanvas does. Seems that if there was a jpeg use
> flag for goocanvas when people create ebuilds for other things that use it
> they would be more likely to include it as a dependency than to include
> gdk-pixbuf[jpeg] which isnt even listed as a dependency of their app.

Implicit dependencies are always a pain. So best to not rely on them (my fault). But sure - having control from goocanvas out has also makes some sense.