Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 616320 - dev-python/cmd2: completely broken on python3.5
Summary: dev-python/cmd2: completely broken on python3.5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal critical (vote)
Assignee: Matthew Thode ( prometheanfire )
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-22 14:51 UTC by Michał Górny
Modified: 2019-07-09 19:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-python:cmd2-0.6.8:20170422-144652.log (dev-python:cmd2-0.6.8:20170422-144652.log,89.00 KB, text/x-log)
2017-04-22 14:51 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-04-22 14:51:35 UTC
Created attachment 470662 [details]
dev-python:cmd2-0.6.8:20170422-144652.log

May I ask why a package installing a single Python module which can't even be loaded with python3.4 is enabled for py3.4?

Traceback (most recent call last):
  File "/usr/lib64/python3.5/runpy.py", line 193, in _run_module_as_main
    "__main__", mod_spec)
  File "/usr/lib64/python3.5/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  File "/tmp/portage/dev-python/cmd2-0.6.8/work/cmd2-0.6.8-python3_5/lib/cmd2.py", line 187, in <module>
    if subprocess.mswindows:
AttributeError: module 'subprocess' has no attribute 'mswindows'


commit 60e68a6dabe2db50c37deff5be553654f9cf67ee
Author:     Matthew Thode <prometheanfire@gentoo.org>
AuthorDate: Sat Mar 26 02:54:41 2016
Commit:     Matthew Thode <prometheanfire@gentoo.org>
CommitDate: Sat Mar 26 02:54:41 2016

    dev-python/cmd2: add py35 support
    
    Package-Manager: portage-2.2.26
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-04-22 14:52:12 UTC
Oh, sorry, it's 3.5. This ultra-verbose test output got me confused.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-04-22 14:58:26 UTC
Damn, I need to rest. 0.6.7 has py3.5 and fails just the same. Which also means now we have a tree of reverse dependencies which have 3.5 enabled and will fail at random point when trying to use cmd2...
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-04-22 15:20:07 UTC
Matthew, I would like to officially request you to fix the mess you've caused. As far as I can see, new cmd2 versions also have a number of test failures, so bumping won't help (unless you're willing to *fix* them).

Therefore, please figure out all reverse dependencies of cliff, and their reverse dependencies, and remove python3_5 from all those packages. Afterwards, please remove python3_5 from cliff and cmd2.

I would also like to request that you do not commit any more Python-related changes to ::gentoo without asking other members of the Python team for prior review.
Comment 4 Mike Gilbert gentoo-dev 2017-04-22 17:05:00 UTC
(In reply to Michał Górny from comment #3)
> I would also like to request that you do not commit any more Python-related
> changes to ::gentoo without asking other members of the Python team for
> prior review.

I understand that you are frustrated, but this seems like an overreaction.
Comment 5 Mike Gilbert gentoo-dev 2017-04-22 18:10:17 UTC
This package seems quite immature in general.

Bumping to 0.7.0 gives a mostly-clean test run, with only one failure. I have disabled the relevant test; hopefully upstream has already fixed it.

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f6342aecbea9102c4dfd05b98d289d81fc434c4

commit 9f6342aecbea9102c4dfd05b98d289d81fc434c4
Author: Mike Gilbert <floppym@gentoo.org>
Date:   Sat Apr 22 14:07:38 2017 -0400

    dev-python/cmd2: bump to 0.7.0
    
    Package-Manager: Portage-2.3.5_p19, Repoman-2.3.2_p49

 dev-python/cmd2/Manifest          |  1 +
 dev-python/cmd2/cmd2-0.7.0.ebuild | 40 +++++++++++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+)
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2019-07-09 19:54:13 UTC
Current version should be fine.