Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 616314 - >=www-client/firefox-52 fails to build on ARM NEON
Summary: >=www-client/firefox-52 fails to build on ARM NEON
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-22 14:16 UTC by Zdeněk Žamberský
Modified: 2017-08-26 18:15 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zdeněk Žamberský 2017-04-22 14:16:29 UTC
Problem is basically that firefox 52.0.2 fails to build for ARM, when NEON is enabled.

From build log:

In file included from /var/tmp/portage/www-client/firefox-52.0.2/work/firefox-52.0.2/gfx/skia/skia/src/core/SkBitmapProcState.cpp:15:0:
/var/tmp/portage/www-client/firefox-52.0.2/work/firefox-52.0.2/gfx/skia/skia/src/core/SkBitmapProcState.cpp: In member function 'bool SkBitmapProcState::chooseScanlineProcs(bool, bool)':
/var/tmp/portage/www-client/firefox-52.0.2/work/firefox-52.0.2/gfx/skia/skia/src/core/SkBitmapProcState.cpp:363:42: error: 'gSkBitmapProcStateSample32' was not declared in this scope
         fSampleProc32 = SK_ARM_NEON_WRAP(gSkBitmapProcStateSample32)[index];
                                          ^
/var/tmp/portage/www-client/firefox-52.0.2/work/firefox-52.0.2/gfx/skia/skia/src/core/SkUtilsArm.h:14:78: note: in definition of macro 'SK_ARM_NEON_WRAP'
     #define SK_ARM_NEON_WRAP(x) (SkCpu::Supports(SkCpu::NEON) ? x ## _neon : x)
                                                                              ^



Reproducible: Always




I already reported this bug to mozilla [1] . And I don't want to just copy-paste my comments, so please take a look there for more details (and full log). I also attached patch [2] to fix this issue there. Upcoming firefox releases will hopefully contain that fix.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1358776
[2] https://bug1358776.bmoattachments.org/attachment.cgi?id=8860634
Comment 1 Jory A. Pratt gentoo-dev 2017-08-26 18:15:13 UTC
Has already been include in esr branch and should be available via the gentoo tree.