Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 616308 - dev-python/genshi: Multiple test failures, incomplete python3 support
Summary: dev-python/genshi: Multiple test failures, incomplete python3 support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-22 13:46 UTC by Michał Górny
Modified: 2017-07-30 21:43 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
dev-python:genshi-0.7:20170422-131439.log (dev-python:genshi-0.7:20170422-131439.log,684.80 KB, text/x-log)
2017-04-22 13:46 UTC, Michał Górny 		Details
genshi-0.7.ebuild (genshi-0.7.ebuild,1.09 KB, text/plain)
2017-07-29 21:15 UTC, Cédric Krier 		Details
genshi-0.7-fix_tests_failure_with_python27.patch (genshi-0.7-fix_tests_failure_with_python27.patch,1.07 KB, patch)
2017-07-29 21:16 UTC, Cédric Krier 		Details | Diff
genshi-0.7-issue566.patch (genshi-0.7-issue566.patch,2.18 KB, patch)
2017-07-29 21:16 UTC, Cédric Krier 		Details | Diff
genshi-0.7-issue582.patch (genshi-0.7-issue582.patch,12.47 KB, patch)
2017-07-29 21:17 UTC, Cédric Krier 		Details | Diff
genshi-0.7-issue602.patch (genshi-0.7-issue602.patch,4.40 KB, patch)
2017-07-29 21:17 UTC, Cédric Krier 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-04-22 13:46:07 UTC 
Created attachment 470638 [details]
dev-python:genshi-0.7:20170422-131439.log

Test results:

python2.7 / pypy: FAILED (failures=1)
python3.4: FAILED (failures=2, errors=19)
python3.[56]: FAILED (failures=4, errors=34)

I would say adding 3.4 to PYTHON_COMPAT is even debatable since the tests clearly indicate it's using python2-isms.

It seems completely dead upstream.

Revdeps:
app-admin/bcfg2 [2.7 only]
dev-python/cement [2.7+3.4]
dev-python/wehjit [2.7]
www-apps/trac [2.7]
www-apps/trac-tags [2.7]
www-apps/venus [2.7]

Of those packages, only cement supports py3.x, and its revdeps are 2.7-only. I'm going to remove 3.x support from cement and genshi.
Comment 1 Cédric Krier gentoo-dev 2017-07-29 21:15:55 UTC 
Created attachment 487240 [details]
genshi-0.7.ebuild

Indeed few patches exist in their repository that fixes the tests.
I'm interested to have Genshi under Python3, so here is an ebuild updated with those patches for which the tests pass.
Comment 2 Cédric Krier gentoo-dev 2017-07-29 21:16:29 UTC 
Created attachment 487242 [details, diff]
genshi-0.7-fix_tests_failure_with_python27.patch
Comment 3 Cédric Krier gentoo-dev 2017-07-29 21:16:47 UTC 
Created attachment 487244 [details, diff]
genshi-0.7-issue566.patch
Comment 4 Cédric Krier gentoo-dev 2017-07-29 21:17:07 UTC 
Created attachment 487246 [details, diff]
genshi-0.7-issue582.patch
Comment 5 Cédric Krier gentoo-dev 2017-07-29 21:17:29 UTC 
Created attachment 487248 [details, diff]
genshi-0.7-issue602.patch
Comment 6 Dirkjan Ochtman (RETIRED) gentoo-dev 2017-07-30 18:46:33 UTC 
LGTM, feel free to go ahead and commit them.