Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 616042 - app-emulation/xen-tools-4.8.0-r5 should at "|| die" after a "source <file>" statement
Summary: app-emulation/xen-tools-4.8.0-r5 should at "|| die" after a "source <file>" s...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Xen Devs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-19 19:33 UTC by Florian Schmaus
Modified: 2017-05-02 09:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
xen-tools-ebuild-add-die.patch (xen-tools-ebuild-add-die.patch,972 bytes, patch)
2017-04-19 19:37 UTC, Florian Schmaus
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Florian Schmaus gentoo-dev 2017-04-19 19:33:13 UTC
While working on a fix for #572304 I found that the xen-tools ebuild does call 'source' at two occasions, but it does not check whether or not statement was successful. This caused by experiments searching for a fix to derail because I had issues with my ebuild (the qemu-bridge-helper was not renamed). Turns out that was because I forget to copy the content of FILESDIR into my overlay, so the 

source "${FILESDIR}"/gentoo-patches.conf

in line 214 failed unnoticed. I suggest using

source "${FILESDIR}"/gentoo-patches.conf || die

instead.
Comment 1 Florian Schmaus gentoo-dev 2017-04-19 19:37:05 UTC
Created attachment 470432 [details, diff]
xen-tools-ebuild-add-die.patch
Comment 2 Yixun Lan archtester gentoo-dev 2017-05-02 09:05:11 UTC
fixed in tree, thanks for reporting this ;-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=911800c0fe06e2c32394d04a19af828257914bd6