Bug 616000 – games-mud/gnome-mud-0.11.2: Upstream fix for permanent disable of telnet options

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Raymond Jennings 2017-04-19 10:57:50 UTC]

https://bugzilla.gnome.org/show_bug.cgi?id=781452

[Comment 1 Raymond Jennings 2017-04-19 11:01:41 UTC]

From 62b043beedc14741a000e848a004ba44982b28b8 Mon Sep 17 00:00:00 2001
From: Steven Jackson <[e-mail]>
Date: Wed, 19 Apr 2017 10:38:18 +0000
Subject: [PATCH] mud-telnet: Fix re-enabling disabled TELOPTS

When the server disabled a TELOPT it wasn't possible for it to
re-enable it, as it should.

Enabling and disabling MSP and CHARSET in the preferences window
doesn't control the MudTelnetHandler enabled field, so this change
doesn't break that. Those preferences are used at a higher level,
in mud-window-view.c.

Thanks to shentino for reporting and assisting with the fix.

Bug report: https://bugzilla.gnome.org/show_bug.cgi?id=781452
---
 src/mud-telnet.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mud-telnet.c b/src/mud-telnet.c
index 052ba04..0fe274a 100644
--- a/src/mud-telnet.c
+++ b/src/mud-telnet.c
@@ -939,7 +939,7 @@ mud_telnet_handle_positive_nego(MudTelnet *telnet,
        // his state to YES and send DO; otherwise send DONT
        // FIXME-US/HIM
        // FIXME: What to do in the opposite "him" gint value case?
-       if (mud_telnet_isenabled(telnet, opt_no, him))
+       if (mud_telnet_get_index_by_option(telnet, opt_no) != -1)
        {
            mud_telnet_set_telopt_state(opt, TELOPT_STATE_YES, bitshift);
            mud_telnet_send_iac(telnet, affirmative, opt_no);
--
1.9.1

[Comment 2 Raymond Jennings 2017-04-19 11:44:08 UTC]

There was a whitespace shuffle upstream.

Please make sure to use tabs instead of spaces if needed.

[Comment 3 Mart Raudsepp 2017-04-19 11:45:36 UTC]

gnome@g.o does not maintain this. Working patches should be attached, not inlined

[Comment 4 Raymond Jennings 2017-04-19 13:17:11 UTC]

Created attachment 470390 [details, diff]
patch

[Comment 5 Mart Raudsepp 2017-04-22 17:27:50 UTC]

If games@ wants, I can co-maintain or maintain gnome-mud personally (not under gnome@).

[Comment 6 Raymond Jennings 2017-04-22 18:18:20 UTC]

+1 from me.  I observed him in direct conversations with upstream.

[Comment 7 James Le Cuirot 2017-04-22 18:23:31 UTC]

(In reply to Mart Raudsepp from comment #5)
> If games@ wants, I can co-maintain or maintain gnome-mud personally (not
> under gnome@).

Go for it.

[Comment 8 Mart Raudsepp 2017-04-22 18:39:56 UTC]

(In reply to Raymond Jennings from comment #6)
> +1 from me.  I observed him in direct conversations with upstream.

For the record, I technically am upstream, just not active when lonely.
https://bugzilla.gnome.org/page.cgi?id=browse.html&product=gnome-mud

[Comment 9 Mart Raudsepp 2017-04-22 21:23:59 UTC]

Added myself as maintainer then.
To include this patch, it'd be a revbump. To revbump, I'd want to fix gstreamer to use 1.0 slot in the same go. To do that, I need to know of a MSP supporting/using MUD server to test this on.

[Comment 10 Mart Raudsepp 2017-07-19 16:25:07 UTC]

commit b745232aa6d172768731cd9e0839730c5c17760c
Author: Mart Raudsepp <[e-mail]>
Date:   Wed Jul 19 19:24:03 2017 +0300

    games-mud/gnome-mud: Use gstreamer 1.x and fix telnet option renegotiation
    
    Gentoo-bug: 616000
    Package-Manager: Portage-2.3.6, Repoman-2.3.2