Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 615896 - www-client/firefox-52.0.2: remove check for non-existing skia use flag on ARM
Summary: www-client/firefox-52.0.2: remove check for non-existing skia use flag on ARM
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: ARM Linux
: Normal normal (vote)
Assignee: Mozilla Gentoo Team
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2017-04-17 21:27 UTC by Zdeněk Žamberský
Modified: 2017-04-19 20:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
removed-check-for-skia-use-flag-on-arm.patch (0001-removed-usage-of-skia-flag-on-arm.patch,828 bytes, patch)
2017-04-17 21:29 UTC, Zdeněk Žamberský 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zdeněk Žamberský 2017-04-17 21:27:28 UTC 
Looks like "skia" use flag has been removed, and skia is now always enabled (except for big endian archs). But check for now non-existing "skia" use flag is still performed on ARM architecture.

Reproducible: Always

Actual Results:  
As the result of this configure phase of firefox-52.0.2 fails with the following error on ARM:

 * ERROR: www-client/firefox-52.0.2::gentoo failed (configure phase):
 *   USE Flag 'skia' not in IUSE for www-client/firefox-52.0.2
 * 
 * Call stack:
 *          ebuild.sh, line  115:  Called src_configure
 *        environment, line 5499:  Called mozconfig_config
 *        environment, line 3821:  Called use 'skia'
 *   phase-helpers.sh, line  200:  Called die
 * The specific snippet of code:
 *   				die "USE Flag '${u}' not in IUSE for ${CATEGORY}/${PF}"
Comment 1 Zdeněk Žamberský 2017-04-17 21:29:07 UTC 
Created attachment 470286 [details, diff]
removed-check-for-skia-use-flag-on-arm.patch
Comment 2 Zdeněk Žamberský 2017-04-17 21:46:50 UTC 
Attached patch fixes error in configuration phase. 
However I have not tried to do full merge on ARM yet.
Comment 3 Ian Stakenvicius (RETIRED) gentoo-dev 2017-04-19 20:33:21 UTC 
Patch looks good to me, committing.

commit 9445706c8848d9817ff7c5a8757eac257e333c67
Author: Ian Stakenvicius <axs@gentoo.org>
Date:   Wed Apr 19 16:31:22 2017 -0400

    mozconfig-v6.52.eclass: remove obsolete USE=skia conditional on arm
    
    Thanks to Zdeněk Žamberský for the patch.
    
    Bug: http://bugs.gentoo.org/615896