On February 26, Gnome Commander 1.6.3 was released. https://github.com/gnome/gnome-commander/releases/tag/1.6.3 I created a pull request for the Gentoo repository already: https://github.com/gentoo/gentoo/pull/4430 A new USE flag ("unique") is also added in the new Gnome Commander ebuild. Reproducible: Always
I'd seriously consider at least IUSE defaulting +unique, seeing as it's some ancient technology using program, so I doubt it uses GtkApplication to avoid needing libunique for this functionality. But I don't know how it behaves with multiple instances of it open, etc. I suspect a mess-up of preferences when changed in one instance if not stored in dconf, etc. But I have no knowledge of this application, its libunique functionality and so on, so just a drive-by comment. Also it is most unfortunate that after half a decade, it still hasn't been able to port away from gnome-vfs to gio and away from libgnome(ui). We really want to be able to last rite those within this year...
(In reply to Mart Raudsepp from comment #1) > I'd seriously consider at least IUSE defaulting +unique, seeing as it's some > ancient technology using program, so I doubt it uses GtkApplication to avoid > needing libunique for this functionality. Do I understand you right that I should considering the following? src_configure() { gnome2_src_configure \ --disable-static \ $(use_enable unique) \ ... Gnome commander does have the ability to run multiple instances at once, as it uses gsettings/dconf for storing most of its settings. Most, as there are some relicts, though. I could sort out if libunique is really needed, if that is what you mean. > But I don't know how it behaves > with multiple instances of it open, etc. I suspect a mess-up of preferences > when changed in one instance if not stored in dconf, etc. > But I have no knowledge of this application, its libunique functionality and > so on, so just a drive-by comment. > Also it is most unfortunate that after half a decade, it still hasn't been > able to port away from gnome-vfs to gio and away from libgnome(ui). We > really want to be able to last rite those within this year... I would love to do this and there is also an open bug on this. But I am very limited regarding the time I could offer for this project. :/
I'm proposing to consider IUSE default, that is, +unique in IUSE list, not just unique. That's all, and just proposing, you as the maintainer know better if it's actually a good idea or not. https://devmanual.gentoo.org/ebuild-writing/eapi/#eapi=1 (IUSE defaults subchapter)
Thanks for making this clear - I got your point now. Actually, since v1.6.0 gcmd uses dconf for its settings, unique is not really needed any more. That's why I made the usage of libunique optional since v1.6.3. See https://gcmd.github.io/2017/02/26/Release-v1-6-3.html. It is currently only used for the single instance mode (so that clicking on the gcmd icon in the start menu results in focussing the currently running instance). But you are right, actually it would be a good idea to remove libunique usage totally. I will add this on my todo list.
Ah, you are upstream too :) So the modern way to do this is via: https://developer.gnome.org/gtk3/stable/GtkApplication.html But apparently that didn't exist yet with gtk2, unless I looked wrong. Single instance can be nice in various instances and intended. Albeit GtkApplication over libunique probably supports stuff like "Create new window instead of focusing the existing one" better (though I think it's actually also focus existing, and then e.g gnome-shell has a "New Window" option under right click in the dock).
Thanks for the explanation. I also found this migration HowTo: https://developer.gnome.org/gio/stable/GApplication.html where it is said, that another option is to use GApplication, which is gkt2. So I will consider using that one for the next bugfix release. Should be not that complicated. :) For the time being I will update the ebuild to use +unique instead of unique. It really makes sense, as long as libunique is used.
Do you have an IRC channel for gcmd? "Porting a couple random gtk2/libgnome apps away from deprecated stuff as target practice" is somewhere in my deep TODO list
There is only a developer mailinglist: https://gcmd.github.io/#maillists. O:-) And there is also a ToDo file in the GnomeCommander project: https://git.gnome.org/browse/gnome-commander/plain/TODO I changed the ebuild to use +unique now. At the same time, I also dropped version 1.6.1 from the Manifest, as v1.6.3 is the latest bugfix release in testing state.
(In reply to Uwe Scholz from comment #8) > I also dropped version 1.6.1 from the Manifest, as v1.6.3 is the latest bugfix release in testing state. I reverted the drop of v1.6.1, as this version is stable already.
I'm getting wrong file size in Manifest for 1.6.3 !!! Expected: 6869824 !!! Got: 6653164 ls -l gnome-commander-1.6.3.tar.xz downloaded from gcmd.github.io gives 6653164
Thank you for reporting this mistake. I created a merge request with a fix for that. It has to be reviewed now.
Created attachment 498134 [details, diff] This is a diff between the ebuild for 1.6.3 and 1.6.4
Please ignore my attachment!!!
