Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 615636 - net-print/hplip-3.16.3 - mdns.c missing includes patch
Summary: net-print/hplip-3.16.3 - mdns.c missing includes patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Daniel Pielmeier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-15 11:52 UTC by locutus378
Modified: 2018-11-12 19:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
PATCH net-print/hplip-3.16.3 mdns.c for missing includes (hplip-3.16.3-mdns-missing-includes.patch,458 bytes, patch)
2017-04-15 11:52 UTC, locutus378
Details | Diff
PATCH net-print/hplip-3.16.3 mdns.c for missing includes, with QA notice header (hplip-3.16.3-mdns-missing-includes.patch,1.14 KB, patch)
2017-04-15 12:39 UTC, locutus378
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description locutus378 2017-04-15 11:52:18 UTC
Created attachment 470088 [details, diff]
PATCH net-print/hplip-3.16.3 mdns.c for missing includes

This patch for protocol/discovery/mdns.c fixes the QA notice.
Comment 1 Andreas Sturmlechner gentoo-dev 2017-04-15 12:00:16 UTC
Please describe the purpose of this fix and add it to the patch header - which QA notice?

@billie, maybe time to stabilise 3.16.11?
Comment 2 locutus378 2017-04-15 12:39:47 UTC
Created attachment 470092 [details, diff]
PATCH net-print/hplip-3.16.3 mdns.c for missing includes, with QA notice header
Comment 3 locutus378 2017-04-15 12:50:14 UTC
Please let me know if you need anything more to address this.
Comment 4 Andreas Sturmlechner gentoo-dev 2017-04-15 18:31:20 UTC
Can you check if this is still required with 3.16.11-r3?
Comment 5 Felix Janda 2017-04-15 18:42:18 UTC
If this[1] repository is accurate, the file hasn't changed since 3.16.2.

[1]: https://anonscm.debian.org/git/printing/hplip.git/log/protocol/discovery/mdns.c?h=upstream/latest&id=7aab19e53df83162ebcf9998e977ddb07009688f
Comment 6 locutus378 2017-04-15 21:52:09 UTC
Yes, I can confirm that the patch is required for ~3.16.11-r3 as well.

The QA notice won't show up until USE=snmp for network printing support.

Does this mean someone needs to ask upstream to address this problem?

OT: The wiki could use more detailed info on how to setup network printing, or perhaps I'm not reading the correct wiki pages for doing this with HPLIP. I'll keep banging away on it and hopefully figure out how to get it done.
Comment 7 Andreas Sturmlechner gentoo-dev 2017-04-17 07:31:44 UTC
Yes please, could you report+submit this upstream?
Comment 8 locutus378 2017-04-17 12:04:39 UTC
OK Andreas, I will report it over at launchpad. It might carry a bit more weight if an actual Gentoo developer reported it but I will give it a try.

Would you please update the Gentoo wiki HPLIP page with a tip for those not using UTF-8 as their LANG/LC_ALL default to use "LC_ALL=C hp-setup" when trying to add a new print queue? I wasted many hours that could have been better used elsewhere if the wiki had mentioned that CUPS > 1.3.3 requires UTF-8 for all communication and if hp-setup is giving problems to export envar LC_ALL=C.

Re this on Gentoo forums that Google did not find on my first 1000 searches:
 https://forums.gentoo.org/viewtopic-t-709937.html

I did finally get remote scanning working, both on a remote Gentoo PC and on an Android running the InSaneScanner app, but still no luck with remote printing via HPLIP, which leads me to believe that I can't use HPLIP on a remote PC to print to the USB attached HP C4280 on the print server PC.

I'm guessing HPLIP will only work with HP devices and won't add a network print queue on a remote unless it is supplied by the HP device itself. If that is the case, that could be clarified on the Gentoo wiki as well. As it stands now, it looks like my remote PC will have to do it like Android does it and submit PDFs to the CUPS queue, since the usual lp* tools on the remote see the CUPS queue.

You can close this bug now. We have done all we can do about it.

Thank you for your time spent looking at it, Andreas.
Comment 9 Daniel Pielmeier gentoo-dev 2018-04-23 19:53:58 UTC
@locutus378: Did you open a bug upstream about this? I can not find it.
Comment 10 Daniel Pielmeier gentoo-dev 2018-11-12 19:05:56 UTC
This should be fixed since hplip-3.18.6-r2.