Bug 61531 – fbzx-1.4 won't work on PPC

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Maciej J. Woloszyk 2004-08-24 09:52:49 UTC]

While the program compiles fine it lacks the necessary changes described in
PORTS file to work properly on PPC (and other big-endian system).

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




So I did a little patch that solved the problem for me. 
 
--------------------------------------------------- fbzx-1.4-endian_patch 
--- fbzx/Z80.h  2003-12-19 21:37:22.000000000 +0100 
+++ fbzx.new/Z80.h      2004-08-24 18:26:50.696481080 +0200 
@@ -12,7 +12,10 @@ 
 /*************************************************************/ 
 #ifndef Z80_H 
 #define Z80_H 
+#include <endian.h> 
+#if __BYTE_ORDER == __LITTLE_ENDIAN 
 #define LSB_FIRST 
+#endif 
                                /* Compilation options:       */ 
 /* #define DEBUG */            /* Compile debugging version  */ 
 /* #define LSB_FIRST */        /* Compile for low-endian CPU */ 
-------------------------------------------------------------------------

[Comment 1 Maciej J. Woloszyk 2004-08-24 09:58:25 UTC]

Created attachment 38104 [details, diff]
fbzx-1.4-endian_patch

[Comment 2 Chris Gianelloni (RETIRED) 2004-08-24 10:14:00 UTC]

Have you checked if this has been fixed upstream?

I only ask so that we know if we should submit the patch to them or not... =]

[Comment 3 Maciej J. Woloszyk 2004-08-24 10:20:09 UTC]

No. I didn't checked as I don't think author of fbzx considers it a bug. There
is a note in PORTS readme stating that when you compile it on big-endian
machine you should remove one #define. What I did is the extension of this
note to automate the build.

[Comment 4 SpanKY 2004-08-26 19:58:18 UTC]

awesome, thanks again

gonna try to contact upstream author ...