Hi, I'm requesting a version bump for app-text/htmldoc Current version in Portage app-text/htmldoc-1.8.29 This version suffers from a serious bug Bug causes a core dump when processing certain input Upstream bug report https://github.com/michaelrsweet/htmldoc/issues/295 Worth noting that app-text/htmldoc-1.8.29 is marked as stable in Portage Bug was fixed upstream on 2017-03-17 Upstream commit that fixes bug https://github.com/michaelrsweet/htmldoc/commit/d289b78d56b9fe0551c2d3e0ebef3c3fa5709ced Fix is included in version 1.8.30 version 1.8.30 was released 2017-03-23 I think this should be all the info needed, but if not, let me know Many Thanks
Hi Tony, it seems like this package lacks a maintainer. Would you like to proxy maintain it?
I'm not entirely sure what "maintaining" would involve, but I am not a C developer... I can confirm that building and installing the upstream source posed no issues Just the usual ./configure; make; make install Forgive my ignorance, but I just assumed rev-bumping a package in Portage was nothing more than copying the existing ebuild, and pointing it to the new source tarball.
Created attachment 469914 [details] PNG image file that causes htmldoc to crash
Created attachment 469916 [details] Input HTML file that references image.png
Created attachment 469918 [details] Error log for 1.8.29 crash
Created attachment 469920 [details] Correctly produced PDF from 1.8.30
If it's not possible to include version 1.8.30, then perhaps cherrypick the commit that fixes bug and patch version 1.8.29? Upstream commit that fixes bug https://github.com/michaelrsweet/htmldoc/commit/d289b78d56b9fe0551c2d3e0ebef3c3fa5709ced I am not confident that I can do this myself, but what I *can* do is produce a simple test-case That way someone who's confident editing C source code can at least verify the fix. See attached HTML and PNG file for input files 1.8.29 (Installed from Portage) ------------------------------- $ /usr/bin/htmldoc --version 1.8.29 $ /usr/bin/htmldoc -t pdf --webpage --outfile output.pdf input.html == See attached file, 1.8.29-error.log == 1.8.30 (Installed from upstream source) --------------------------------------- $ /usr/local/bin/htmldoc --version 1.8.30 $ /usr/local/bin/htmldoc -t pdf --webpage --outfile output.pdf input.html == See attached file, 1.8.30-output.pdf ==
(In reply to Tony from comment #2) > I'm not entirely sure what "maintaining" would involve, but I am not a C > developer... > > I can confirm that building and installing the upstream source posed no > issues > Just the usual > > ./configure; make; make install > > Forgive my ignorance, but I just assumed rev-bumping a package in Portage > was nothing more than copying the existing ebuild, and pointing it to the > new source tarball. Maintaining means taking care of, fixing bugs if they arise, opening pull-requests for new bumps. Sometimes it's trivial as you say, sometimes there are breaking changes, it really depends on the package. You can get more information here: https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers
(In reply to Tony from comment #7) > If it's not possible to include version 1.8.30, > then perhaps cherrypick the commit that fixes bug and patch version 1.8.29? Seems no one is interested in this package right now, so if you want to make the change, you can do it :) You can check other pull requests on github: https://github.com/gentoo/gentoo/pulls And you can create your own there.
Hi Tony, I've just added v1.8.30 to the tree. Please test and let me know if you experience any problems (you can comment on this bug, or file a new one assigned to me).
Brilliant, Can confirm no issues with 1.8.30 Many thanks
