Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 61468 - findlib eclass: Small buglet?
Summary: findlib eclass: Small buglet?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Matthieu Sozeau (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-23 22:42 UTC by Bardur Arantsson
Modified: 2004-08-24 07:35 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bardur Arantsson 2004-08-23 22:42:58 UTC
Hi,

Sorry to keep pestering you :), but I noticed that the findlib eclass doesn't check for errors: AFAICT

     dodir ${destdir}

should be 

     dodir ${destdir} || die

and

    make DESTDIR=${D} "$@" install

should be

    make DESTDIR=... || die

otherwise you might end up with horribly broken ebuilds without noticing from just installing them.

(Also, just as an aside I also noticed that the following ebuilds could trivially be moved to to the findlib.eclass: pxp-1.1.6, pomap-2.9.4, and *probably* ulex-0.5. Just thought I'd mention it in case you'd missed them).
Comment 1 Matthieu Sozeau (RETIRED) gentoo-dev 2004-08-24 07:35:13 UTC
No problem, I fixed findlib.eclass in CVS and will progressively change every package to use findlib where possible.