Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 614484 - virtual/linux-sources-2[firmware]: incorrectly satisfied by sys-kernel/linux-firmware alone
Summary: virtual/linux-sources-2[firmware]: incorrectly satisfied by sys-kernel/linux-...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Anthony Basile
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-02 04:16 UTC by Garry Filakhtov
Modified: 2017-04-02 22:18 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Garry Filakhtov 2017-04-02 04:16:08 UTC
After upgrading to virtual/linux-sources-2 I noticed that portage tries to remove gentoo-sources during depclean.

After looking at linux-sources-2.ebuild I was confused, because

RDEPEND="|| (
		firmware? ( sys-kernel/linux-firmware )
		sys-kernel/gentoo-sources
		sys-kernel/vanilla-sources
		sys-kernel/ck-sources
		sys-kernel/git-sources
		sys-kernel/hardened-sources
		sys-kernel/mips-sources
		sys-kernel/openvz-sources
		sys-kernel/pf-sources
		sys-kernel/rt-sources
		sys-kernel/tuxonice-sources
		sys-kernel/xbox-sources
		sys-kernel/zen-sources
		sys-kernel/aufs-sources
		sys-kernel/raspberrypi-sources
	)"

basically says that it is enough to have sys-kernel/linux-firmware installed if firmware flag is given which does not pull in an actual kernel sources.

I think that correct RDEPEND should be as follow:

RDEPEND="
	firmware? ( sys-kernel/linux-firmware )
	|| (
		sys-kernel/gentoo-sources
		sys-kernel/vanilla-sources
		sys-kernel/ck-sources
		sys-kernel/git-sources
		sys-kernel/hardened-sources
		sys-kernel/mips-sources
		sys-kernel/openvz-sources
		sys-kernel/pf-sources
		sys-kernel/rt-sources
		sys-kernel/tuxonice-sources
		sys-kernel/xbox-sources
		sys-kernel/zen-sources
		sys-kernel/aufs-sources
		sys-kernel/raspberrypi-sources
	)"

Correct me if I wrong. Thanks in advance.
Comment 1 Anthony Basile gentoo-dev 2017-04-02 15:53:06 UTC
(In reply to Garry Filakhtov from comment #0)
\
> 
> Correct me if I wrong. Thanks in advance.

oh no.  you're right.  my bad and i'll fix it now.
Comment 2 Anthony Basile gentoo-dev 2017-04-02 16:00:16 UTC
(In reply to Anthony Basile from comment #1)
> (In reply to Garry Filakhtov from comment #0)
> \
> > 
> > Correct me if I wrong. Thanks in advance.
> 
> oh no.  you're right.  my bad and i'll fix it now.

please test and reopen this bug if its still a problem.
Comment 3 Garry Filakhtov 2017-04-02 22:18:57 UTC
Hi Anthony,

Thanks a lot for fast reaction and quick fix!
I can confirm that after upgrade problem is solved.

Cheers,
Garry