Bug 613252 – dev-db/redis-3.2.5: Service status problems

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Phil Stracchino (Unix Ronin) 2017-03-19 19:14:52 UTC]

I recently installed dev-db/redis as a dependency for mail-filter/rspamd, as part of a project to replace the defunct mail-filter/dspam.  Redis appears to start up correctly, but the init scripts are clearly broken.  Once the redis service is started, rc-status always reports its status as 'crashed', and rc-service cannot stop or restart it.


minbar:root:~:13 # pgrep -alf redis
19366 /usr/sbin/redis-server 127.0.0.1:6379
minbar:root:~:14 # rc-status | grep redis
 redis                                                             [  crashed  ]
minbar:root:~:15 # rc-service redis stop
 * Stopping redis ...
 * start-stop-daemon: no matching processes found                                                                         [ ok ]
minbar:root:~:16 # pgrep -alf redis
19366 /usr/sbin/redis-server 127.0.0.1:6379

[Comment 1 taylor.tim.j 2017-03-31 19:51:45 UTC]

Created attachment 468812 [details, diff]
The patched init script

Pull out the background and pidfile options in the start-stop-daemon args.

[Comment 2 taylor.tim.j 2017-03-31 19:52:36 UTC]

Created attachment 468814 [details, diff]
The diff of the fixed and original init scripts.

The diff between new and old.

[Comment 3 taylor.tim.j 2017-03-31 19:56:49 UTC]

The issue happens because redis wants to handle it's own pid, but the init script passes background and pid info to start-stop-daemon. Solution is just to pull out those params from the args.

[Comment 4 Phil Stracchino (Unix Ronin) 2017-03-31 22:08:48 UTC]

Confirmed fix works for me.

[Comment 5 Austin English (RETIRED) 2017-04-10 17:29:49 UTC]

The patch has been committed here:
https://github.com/gentoo/gentoo/commit/6f9cc73493d498749aadc4322ba0a8accda697b8

and all the ebuilds have been revbumped as well so users can get the udpates.