The ebuild suffers from multiple severe QA violations: - Ebuilds must not modify files in DISTDIR (with very few exceptions, like live ebuilds). Otherwise, Manifest verification will fail when the distfile is fetched for the next time. Neither should permissions of the files be changed. - Especially, patching of the sources must not be done in pkg_setup but in src_prepare. - The DISTDIR variable is not valid in pkg_* phases. This concerns both pkg_nofetch and pkg_setup. PMS reference: https://projects.gentoo.org/pms/6/pms.html#x1-11800011.1 - Why is renaming of the desktop entry file (last line in src_install) needed?
Created attachment 467906 [details, diff] genymotion-2.8.1-r1.patch
(In reply to Ulrich Müller from comment #0) > The ebuild suffers from multiple severe QA violations: > > - Ebuilds must not modify files in DISTDIR (with very few exceptions, like > live ebuilds). Otherwise, Manifest verification will fail when the distfile > is fetched for the next time. Neither should permissions of the files be > changed. > > - Especially, patching of the sources must not be done in pkg_setup but in > src_prepare. > > - The DISTDIR variable is not valid in pkg_* phases. This concerns both > pkg_nofetch and pkg_setup. > PMS reference: https://projects.gentoo.org/pms/6/pms.html#x1-11800011.1 Solved in proposed patch. > - Why is renaming of the desktop entry file (last line in src_install) > needed? It's only a "cosmetic changes", without this file is named "_opt_genymotion_genymotion-genymotion-bin.desktop".
(In reply to Marco Genasci from comment #1) > Created attachment 467906 [details, diff] [details, diff] > genymotion-2.8.1-r1.patch Ack, this looks much better.
Revbump is available in the tree now. Thanks
DISTDIR is still referenced in pkg_nofetch (I missed that in the previous round). It is not critical because it affects an einfo message only. But maybe you could fix it with the next version bump.
