The ebuild tries to access ${DISTDIR} in pkg_setup where the variable is not valid. Also, while SRC_URI is empty, it accesses a file in ${DISTDIR} in src_unpack, bypassing Manifest checksum verification. PMS reference: https://projects.gentoo.org/pms/6/pms.html#x1-11800011.1 Further issues: - Still uses games.eclass - HOMEPAGE returns 404 - RESTRICT="bindist" is missing (also "mirror" once the file is properly added to SRC_URI)
Funny, this hasn't been touched in years but it just so happens I've been working on it this week. I noticed the DISTDIR thing and figured that was bad. I don't think it would even work as DISTDIR is a filtered view of the files? I don't think RESTRICT="mirror" will apply as there won't be a URL for the data file. There will be an additional patch file in SRC_URI and that can be mirrored. Is RESTRICT="bindist" actually necessary? I'm not sure if the rule applies to commercial data files. I've also fixed the HOMEPAGE and removed games.eclass. I'm just making some final tweaks before I get it all pushed.
(In reply to James Le Cuirot from comment #1) > I noticed the DISTDIR thing and figured that was bad. I don't think it would > even work as DISTDIR is a filtered view of the files? Right, modern portage versions set up a shadow dir containing only the files in ${A}. (Not sure if that exists in pkg_* though, but PMS says that DISTDIR is not valid there anyway.) > Is RESTRICT="bindist" actually necessary? I'm not sure if the rule applies > to commercial data files. Definitely. The license explicitly forbids distribution, and that will apply to binpkgs too.
Fixed in 1.2. Needs stabilising.
(In reply to James Le Cuirot from comment #3) > Fixed in 1.2. Needs stabilising. No stable games-* currently, and 1.0 is long gone. Closing.
