Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 612882 - ebuild-writing/functions/pkg_nofetch references the DISTDIR variable
Summary: ebuild-writing/functions/pkg_nofetch references the DISTDIR variable
Status: RESOLVED FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Devmanual (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Devmanual Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-17 10:00 UTC by Ulrich Müller
Modified: 2019-03-19 18:23 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Change the pkg_nofetch example and add a note (0001-ebuild-writing-functions-pkg_nofetch-Do-not-referenc.patch,1.30 KB, patch)
2017-03-17 10:00 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ulrich Müller gentoo-dev 2017-03-17 10:00:29 UTC
Created attachment 467290 [details, diff]
Change the pkg_nofetch example and add a note

According to PMS, the DISTDIR variable is not valid in pkg_* phases. In addition, it is not guaranteed to be consistent across the ebuild environment. So the package manager is allowed to (and Portage does in some phases) redefine it to point to a temporary "shadow" instead of the global distfiles directory.

Since I see very little value in explicitly expanding ${DISTDIR} in that einfo message, I think we can simply change it to describe the directory instead.

PMS reference: https://projects.gentoo.org/pms/6/pms.html#x1-118002
Comment 1 Göktürk Yüksek archtester gentoo-dev 2017-03-18 16:51:09 UTC
12:46:44   +gokturk | ulm: ack wrt #612882. In ebuild-writing/variables, we say that ROOT is only allowed in pkg_* phases. maybe we should do something similar for DISTDIR?
Comment 2 Ulrich Müller gentoo-dev 2017-03-18 19:34:57 UTC
This concerns not only DISTDIR but most of the variables describing a path. See the PMS 11.1 table I cited above.
Comment 3 Brian Evans (RETIRED) gentoo-dev 2019-03-19 18:23:36 UTC
Committed with id fd5633bbea42e0a0 on Fri Mar 17 10:41:55 2017 +0100