Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 612782 - sys-kernel/ck-sources-4.10.2 missing default to src_prepare
Summary: sys-kernel/ck-sources-4.10.2 missing default to src_prepare
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: kuzetsa CatSwarm (kuza for short)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-16 04:01 UTC by kuzetsa CatSwarm (kuza for short)
Modified: 2017-03-16 09:39 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge =sys-kernel/ck-sources-4.10.2::gentoo --verbose --ask (file_612782.txt,5.13 KB, text/plain)
2017-03-16 04:01 UTC, kuzetsa CatSwarm (kuza for short)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kuzetsa CatSwarm (kuza for short) 2017-03-16 04:01:25 UTC
Created attachment 467180 [details]
emerge =sys-kernel/ck-sources-4.10.2::gentoo --verbose --ask

This regression is caused by the bump from EAPI 5 to 6

Likely clue:

> eapply_user (or default) must be called in src_prepare()
Comment 1 kuzetsa CatSwarm (kuza for short) 2017-03-16 04:07:56 UTC
https://archives.gentoo.org/gentoo-dev/message/f4b8ba37e652413910e9cc545cfbf0c9

^ I'm not sure what's going on with these changes in EAPI 6. As a short-term workaround, it may be best to simply roll back to EAPI 5.
Comment 2 kuzetsa CatSwarm (kuza for short) 2017-03-16 04:46:42 UTC
Adding the word "default" in the relevant location fixes this issue - it's required now, because the default action doesn't automatically happen by default any more in EAPI 6 for some reason?

Tested the fix and it works, should be fixed/available in the portage tree soon.

Sorry about that.
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-03-16 08:00:16 UTC
There were no default action in previous EAPIs.
Comment 4 kuzetsa CatSwarm (kuza for short) 2017-03-16 08:39:10 UTC
(In reply to Michał Górny from comment #3)
> There were no default action in previous EAPIs.

That's a fair point, sure... I was just assuming based on the available information and context, but consequently this means the regression makes even less sense than I thought?

I don't know why this change is needed, or whatever the root cause is for this particular issue, so maybe I can't describe it well enough to correctly identify and/or title the bug.

If you have a better understanding of what the cause of the issue is, feel free to document said issue(s) behind this bug and/or change the title of the bug as you see fit.
Comment 5 Amy Liffey gentoo-dev 2017-03-16 08:39:27 UTC
commit 67833d6e01bdc8a4b297984e5a04285b01cad7de
Author: kuzetsa <kuzetsa@gmail.com>
Date:   Thu Mar 16 00:26:12 2017 -0400

    sys-kernel/ck-sources: resolve EAPI 5/6 regression
    
    Closes:#4211
    Gentoo-Bug: #612782
Comment 6 Michael Palimaka (kensington) gentoo-dev 2017-03-16 09:39:33 UTC
(In reply to kuzetsa from comment #4)
> I don't know why this change is needed, or whatever the root cause is for
> this particular issue, so maybe I can't describe it well enough to correctly
> identify and/or title the bug.

In EAPI 6 is there is a requirement that eapply_user be called in src_prepare. This could occur either by calling the function directly in an overriden src_prepare or indirectly (eg. via default). There is no such requirement in earlier EAPIs.