Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 61256 - nvidia-kernel-1.0.61111 won't compile with mm-sources-2.6.8.1-r3
Summary: nvidia-kernel-1.0.61111 won't compile with mm-sources-2.6.8.1-r3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: x86 Linux
: High normal (vote)
Assignee: Gentoo X packagers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-08-22 07:44 UTC by Li Zhengang
Modified: 2004-08-27 09:53 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Li Zhengang 2004-08-22 07:44:38 UTC
nvidia-kernel complaining about an undeclared macro "PM_SAVE_STATE":


Reproducible: Always
Steps to Reproduce:
1.emerge -v mm-sources
2.emerge -v nvidia-kernel
3.

Actual Results:  
/gentoo/var/tmp/portage/nvidia-kernel-1.0.6111/work/NVIDIA-Linux-x86-1.0-6111-pkg1/usr/src/nv/nv.c:
In function `nv_acpi_event':
/gentoo/var/tmp/portage/nvidia-kernel-1.0.6111/work/NVIDIA-Linux-x86-1.0-6111-pkg1/usr/src/nv/nv.c:3697:
error: `PM_SAVE_STATE' undeclared (first use in this function)


I looked through the 2.6.8.1-mm3 sources, only found a "PM_SUSPEND" defined
together with PM_RESUME. the latter is used in the other switch-case in the same
function of former.
I changed PM_SAVE_STATE to PM_SUSPEND(nv.c:3697). the compilation went fine.
still donno what would happend after the reboot.
btw: in a OVERLAYED 2.6.8.1-mm2 ebuild, there's no such problem. so this is a
change in mm3?
Comment 1 Andrew Bevitt 2004-08-22 11:51:13 UTC
We cant just change the case choice value, we need both for kernels that dont have the change... Attach a patch something to the following

PM_SUSPEND:
PM_SAVE_STATE:
  ....whatever happens after PM_SUSPEND
Comment 2 Andrew Bevitt 2004-08-27 09:53:27 UTC
Seems they removed the macro in favour of PM_SUSPEND only existing...

Have patched and commited to cvs, closing (works on 2.6.9-* aswell)